Skip to content

tools: improve nix-changes coverage - #65403

Open
aduh95 wants to merge 8 commits into
nodejs:mainfrom
aduh95:list-requisites.sh
Open

tools: improve nix-changes coverage#65403
aduh95 wants to merge 8 commits into
nodejs:mainfrom
aduh95:list-requisites.sh

Conversation

@aduh95

@aduh95 aduh95 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

nix-changes was not tracking a few deps, either because they are associated with a disabled-by-default feature (e.g. QUIC), or some of them are loaded only when shared deps are disabled (e.g. Cargo, rustc). FWIW here's the full list (for aarch64-darwin):

/nix/store/xnf2hlnjmmi59r6c1nzy018759xlp5pk-cargo-1.97.1
/nix/store/cvmhxg0ac3pvrc1xnrrzf9wzd93h1xp9-mock-ada.pc
/nix/store/6zjwbncmf5c6jvhn8ks4v0ikwv41z287-mock-gtest.pc
/nix/store/r1adn84shdm3xbl5i675yprpya5d76cx-mock-hdr_histogram.pc
/nix/store/pbhrzg1rxlrldz52ixwww7n51iy4p10i-mock-libbrotlidec.pc
/nix/store/1m3c56c3ly0lgn8b32j6656gaabvh4qj-mock-libbrotlienc.pc
/nix/store/127lkkhf4l5nf4lrmh0fri8xjvh69v6m-mock-libcares.pc
/nix/store/7zd53bzx6ps0kx9a1cqqpznhjrbzvgr8-mock-libllhttp.pc
/nix/store/jhcnx5hain2l2dcmfii79vhrghngvx07-mock-libnghttp2.pc
/nix/store/q18hrd66ganw7ywlzw553vm95hvymcm7-mock-libnghttp3.pc
/nix/store/8gc50b10s7s9kh8ism2s6ls81ncmmdmj-mock-libngtcp2.pc
/nix/store/c16rc2r8i4xmmv150dvbya9jkcs2csif-mock-libuv.pc
/nix/store/vljl715yrnzgkfy7dcdb9mww3s8n77c7-mock-libzstd.pc
/nix/store/vgknfwwzyb43fml6pal11idvnlg0rb6m-mock-merve.pc
/nix/store/jgijp74zxrc05h92fsfdjdda9spny71a-mock-nbytes.pc
/nix/store/bf6f0bxg87p2waqkbkzwvb0ii9h315f3-mock-simdjson.pc
/nix/store/pl4096rffia5bnifcihvs5lnvs2r28zv-mock-uvwasi.pc
/nix/store/kvj6kinf8i68j4s8gmrh98xcr9zp2d0c-mock-zlib.pc
/nix/store/p3az4xy8h1dmbfqmk4bkk554nk2hnn6h-nghttp3-1.16.0-doc
/nix/store/c4kj460dxdmh2yf0cm137id0dbr6il1s-ngtcp2-1.23.0-doc
/nix/store/w9b2fv3j3azynl03gv5k38lh5cp2bf87-non-v8-deps-mock-0.0.0-mock
/nix/store/i2h5jr4mlziqbsm3jblp88z9jgw5dbf3-patchutils-0.3.4
/nix/store/8wmdpik778pdqqz3azmz93b0f4wyi30m-pkg-config-0.29.2
/nix/store/lqahvywm9fgdhi7lwz4y56dkamsg7z0s-pkg-config-wrapper-0.29.2
/nix/store/jinvhlljv474cr5640ywd5c124kgp8sc-rustc-1.97.1
/nix/store/sznk0bnbp1s4gn4an0a3405wvg4nxjfj-rustc-1.97.1-doc
/nix/store/iz85qysxs639gy77463yhn1259znvzdq-rustc-1.97.1-man
/nix/store/sbrjwqjkbc07drlcni93y51jlcmll8kq-rustc-wrapper-1.97.1
/nix/store/zyvpf2x8hfp3gl6561zr8fa6qkzqcj08-rustc-wrapper-1.97.1-doc
/nix/store/mlg531ry8nj53w0pl8n58hgyd07g8nld-rustc-wrapper-1.97.1-man
/nix/store/glh75y9a0a4pdzfzyj0n5nn1gn96451d-temporal_capi-0.2.5
/nix/store/jh80m54hnwvpbv43hhr5lrqbbakkpbrz-validate-pkg-config

I'm moving it to a separate script so it can be linted, and hopefully is more readable. That should also remove the need for #64967 as the script would be affected by git reset HEAD^ --hard

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 19, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 20, 2026
@aduh95
aduh95 requested a review from panva August 20, 2026 07:40
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants