Skip to content

Standardize SS3 derived quantity variable names - #408

Merged
Schiano-NOAA merged 6 commits into
mainfrom
copilot/update-variable-naming-conventions
Oct 15, 2026
Merged

Schiano-NOAA merged 6 commits into
mainfrom
copilot/update-variable-naming-conventions

Conversation

Copilot AI commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Several SS3 aliases used inconsistent or abbreviated names for spawning biomass and annual fishing mortality. This change aligns the four derived-quantity labels with the package’s expanded naming convention.

  • Alias updates: Use spawning_biomass_ratio for Bratio, and expand the three annF_* aliases to annual_fishing_mortality_*.
  • Regression coverage: Assert the expected aliases in the SS3 variable-name resource.
Bratio   → spawning_biomass_ratio
annF_MSY → annual_fishing_mortality_msy

Co-authored-by: Schiano-NOAA <125507018+Schiano-NOAA@users.noreply.github.com>
Copilot AI changed the title [WIP] Update variable naming conventions in ss3_var_names.csv Standardize SS3 derived quantity variable names Oct 9, 2026
Copilot AI requested a review from Schiano-NOAA October 9, 2026 13:40
@Schiano-NOAA

Copy link
Copy Markdown
Collaborator

@copilot please remove the test form the PR. Please also go through the rest of the csv files in that folder and check to make sure any mention of "spawning_potential_ratio" is set to "spr"

Co-authored-by: Schiano-NOAA <125507018+Schiano-NOAA@users.noreply.github.com>

Copilot AI commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please remove the test form the PR. Please also go through the rest of the csv files in that folder and check to make sure any mention of "spawning_potential_ratio" is set to "spr"

Removed the regression test and changed all six matching SS3 aliases to use spr. No resource CSVs retain spawning_potential_ratio. Committed as c9e8827.

… by c9e8827 Use SPR abbreviation in SS3 labels) [skip ci]
@Schiano-NOAA
Schiano-NOAA marked this pull request as ready for review October 14, 2026 20:17
@Schiano-NOAA
Schiano-NOAA merged commit 6478695 into main Oct 15, 2026
9 checks passed
@Schiano-NOAA
Schiano-NOAA deleted the copilot/update-variable-naming-conventions branch October 15, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handful of Variable Naming Convention Things

2 participants