Repository navigation
fix: always run public callers' jobs on GitHub-hosted runners - #93
Merged
Merged
Conversation
secret-scan, lint-workflows, dependabot-auto-merge and claude-code-review default runs-on to the self-hosted pool, and their comments said no public repo consumes them. Nine public nkg/* repos do. The ones that left runs-on unset, or had no self-hosted runner registered, queued for 24h and were cancelled on every run, and a self-hosted pool would run fork PRs' code on our own hosts. Each job's runs-on now resolves to the hosted label whenever github.event.repository.visibility is "public", overriding the input. Private callers are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A9MVeJNZcr9jAqT62a71i6
This was referenced Oct 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A9MVeJNZcr9jAqT62a71i6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A9MVeJNZcr9jAqT62a71i6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secret-scan,lint-workflows,dependabot-auto-mergeandclaude-code-reviewdefaultruns-onto the self-hosted pool (3.6.0), and their comments said no public repo consumes them. Six publicnkg/*repos make ten calls tosecret-scanorlint-workflows.runs-onunset queued for 24h and were cancelled on every run. Today that'slint-workflowsinnkg/gha-token-serverandnkg/distrobuilder-proxmox-lxc-images; before fix(ci): keep the shared reusables on GitHub-hosted runners gha-nomad-dispatcher#32 it was alsonkg/gha-nomad-dispatcher. A self-hosted pool would also run fork PRs' code on our own hosts.runs-onis nowfromJSON(github.event.repository.visibility == 'public' && '["ubuntu-latest"]' || inputs.runs-on)(ubuntu-24.04for the review job). Public repos always get hosted runners, whatever input they pass. Private callers are unchanged.Notes
repositoryobject, the job falls back to the input. Public callers should keep passing a hostedruns-ontoo.v3tag, so they only pick this up when it's released andv3is moved.Test plan
actionlintpassesyamllintreports no new warnings (three existing line-length warnings inclaude-code-review.yml)lint-workflowsrun innkg/gha-token-serverstarts on a hosted runner🤖 Generated with Claude Code
https://claude.ai/code/session_01A9MVeJNZcr9jAqT62a71i6