Skip to content

Refresh #24 (MCP 2026 wire alignment): body is partly outdated and has no implementation: Issue #78 - #91

Open
Shreyavemana wants to merge 4 commits into
nitrocloudofficial:developfrom
Shreyavemana:feat/24-wire-alignment-refresh
Open

Shreyavemana wants to merge 4 commits into
nitrocloudofficial:developfrom
Shreyavemana:feat/24-wire-alignment-refresh

Conversation

@Shreyavemana

Copy link
Copy Markdown
Collaborator

Summary

Addresses (#78), which updates the requirements for (#24) to align the SDK's wire behavior with the MCP 2026 protocol.

Changes

  • Ping behavior: Return -32601 (METHOD_NOT_FOUND) for ping requests in auto and modern protocol modes while preserving legacy behavior.
  • Missing client capability error: Added MISSING_REQUIRED_CLIENT_CAPABILITY with error code -32021.
  • Task capability validation: Return -32021 when a tool is invoked as a task but task support is unavailable for the active protocol version.
  • Discovery metadata: Added io.modelcontextprotocol/serverInfo to the _meta field of server/discover responses.
  • Result type: Ensure discovery responses include resultType: "complete".
  • HTTP-level tests: Added tests/test_mcp26_wire.py to cover the updated wire behavior.

Tests

Added:

  • tests/test_mcp26_wire.py
    • Verifies protocol-specific ping behavior.
    • Covers the missing client capability error.
    • Checks discovery metadata and MCP 2026 response behavior.

Verification

  • tests/test_mcp26_wire.py — 11 passed .
  • tests/test_transport_http.py and tests/test_lifecycle_http.py — 11 passed in an run.

Note: Re-run the tests after rebasing onto upstream/develop to confirm the final results.

Related Issues

@Shreyavemana Shreyavemana changed the title all the changes made Refresh #24 (MCP 2026 wire alignment): body is partly outdated and has no implementation: Issue #78 Oct 26, 2026
@Shreyavemana
Shreyavemana force-pushed the feat/24-wire-alignment-refresh branch from 00fca85 to 7c6fb23 Compare October 27, 2026 05:03
@Shreyavemana
Shreyavemana marked this pull request as draft October 27, 2026 05:05
@Shreyavemana
Shreyavemana marked this pull request as ready for review October 27, 2026 09:45
@Shreyavemana
Shreyavemana force-pushed the feat/24-wire-alignment-refresh branch from 16ce93a to 6a21126 Compare October 27, 2026 10:09
@Shreyavemana
Shreyavemana force-pushed the feat/24-wire-alignment-refresh branch from 6436b7f to c4fea47 Compare October 30, 2026 10:40
@AadarshM07
AadarshM07 requested a balanced review from Copilot October 30, 2026 12:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@AadarshM07
AadarshM07 self-requested a review October 30, 2026 12:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants