Add support for SVG - #1995
Open
yurybubnov wants to merge 1 commit into
Open
Conversation
yurybubnov
force-pushed
the
svg-image-support
branch
from
August 26, 2026 04:09
ea2a0c2 to
8ad728d
Compare
Signed-off-by: Yury Bubnov <ybubnov@gmail.com>
yurybubnov
force-pushed
the
svg-image-support
branch
from
August 26, 2026 04:10
8ad728d to
49241cf
Compare
enjeck
requested changes
Aug 29, 2026
enjeck
left a comment
enjeck
left a comment
Contributor
There was a problem hiding this comment.
Please add screenshots/media showing this working
| continue | ||
| } | ||
| try { | ||
| const response = await axios.get(url, { responseType: 'blob' }) |
Contributor
There was a problem hiding this comment.
The cache is only filled after the fetch completes, so two quick re renders can fetch the same SVG twice?
| html: '', | ||
| md, | ||
| // attachment URL -> object URL of the retyped SVG blob | ||
| svgObjectUrls: {}, |
Contributor
There was a problem hiding this comment.
Is this reused across notes?
Comment on lines
+77
to
+80
| mounted() { | ||
| // the initial onUpdate() runs before the DOM exists | ||
| this.hydrateSvgImages() | ||
| }, |
Contributor
There was a problem hiding this comment.
why do we need this if we have onUpdate ?
| try { | ||
| const response = await axios.get(url, { responseType: 'blob' }) | ||
| const blob = response.data | ||
| const objectUrl = URL.createObjectURL(blob.slice(0, blob.size, 'image/svg+xml')) |
Contributor
There was a problem hiding this comment.
does this do same thing?
Suggested change
| const objectUrl = URL.createObjectURL(blob.slice(0, blob.size, 'image/svg+xml')) | |
| const objectUrl = URL.createObjectURL(new Blob([blob], { type: 'image/svg+xml' })) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Notes as backend for Obsidian with Excalidraw and Ink plugins.
Both plugins export into SVG but Notes doesn't display SVG images, only show them as downloadable attachment.
This PR adds support to display SVG images.
Testes on my installation NextCloud 34.0.2
Assisted-by: ClaudeCode:opus-5
🤖 AI (if applicable)