chore: Update psalm to v6.16.0 - #13525
Draft
kesselb wants to merge 1 commit into
Draft
Conversation
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Contributor
Author
I'd forgot 馃檲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refined version of #11224
Psalm works on CI, but is broken locally with newer PHP versions.
Main different to the previous attempt: psalm/phar is moved to vendor-bin and merged with psalm-stubs. composer.json forces php to 8.1 (for nextcloud 32). For psalm itself that is not necessary (and covered by the php version in psalm.xml). Moving the vendor-bin allows to use the latest version.
Using vimeo/psalm (instead of the phar) failed with
Fatal error: Cannot redeclare function Amp\delay() (previously declared in vendor/amphp/amp/lib/functions.php:131) in vendor-bin/psalm/vendor/amphp/amp/src/functions.php on line 64, hence we stick with phar for now.馃 AI (if applicable)