Skip to content

fix: review of OutOfOffice settings form - #13497

Open
madbob wants to merge 2 commits into
nextcloud:mainfrom
madbob:issue_9975
Open

fix: review of OutOfOffice settings form#13497
madbob wants to merge 2 commits into
nextcloud:mainfrom
madbob:issue_9975

Conversation

@madbob

@madbob madbob commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Totally unrequested review of the OOO settings form, migrated to Nc* components.

Boldest changes:

  • replacement of internal TextEditor with generic NcTextArea, applied because - after all - HTML editing was already disabled and it is not that different
  • settings are hidden when "autorespond" is "off". The previous conditions to disable edit fields were, anyway, broken (this.enabled was tested as a boolean, while it is always a string), and my personal (and questionable!) opinion is that hiding unrequired components from the crowded settings panel helps in making it more readable
sample

Fixes #9975

@kesselb

kesselb commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Thanks, could you take a look at the conflicts?

replacement of internal TextEditor with generic NcTextArea, applied because - after all - HTML editing was already disabled and it is not that different

Newlines are not working anymore

madbob added 2 commits August 21, 2026 00:43
Signed-off-by: Roberto Guido <info@madbob.org>
Signed-off-by: Roberto Guido <info@madbob.org>
@madbob

madbob commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

I've preferred to entirely drop plaintext/HTML/plaintext conversion, and just use the bare version of the string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account settings autoresponder options text alignment

3 participants