Repository navigation
Make do_increase a method of jitcdde - #69
Merged
Merged
Conversation
Contributor
|
Looks good. I wonder why I ever did it that way. I blame premature optimisation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves
do_integrationout ofset_integration_parametersand makes it an actual method of the class.The motivation for this was that calling
set_integration_parameterswas making the code issue warnings like this on teardownThis turned out to be because of
do_increasecreating a closure that capturedselfand then theself.do_increase = do_increasecreated a nice reference cycle. That made the cleanup of the temporary directory in__del__not fire correctly (it did still fire, just not in the right order?). This breaks the reference cycle so that warning no longer shows up.