Repository navigation
Release NetLab 0.6.0 for NetGraph 0.26 and NetLab-TopoGen 0.6.1 - #7
Merged
Merged
Conversation
Pin ngraph>=0.26.0,<0.27 and netlab-topogen>=0.6.1,<0.7 and move the code, tests and configurations to the new APIs: - one shared result reader (netlab/results.py): steps by name, whole units times the units report's q, converged rows and totals; - MSD alpha is NetGraph's alpha_feasible; a null alpha fails the run with reason none_feasible; - TE latency percentiles come from the marginal curve, WES from each row's mean path cost; - the baseline's sampled draws count; BAC adds one baseline reference; - step durations are measured with step_hook and kept in a run record beside the results, so a cache hit keeps them; - grouped combine rows are labelled by selectors and group rosters; - provenance records NetLab's commit only for a clean tree; - skills pinned to 473c45b. The fixtures are regenerated on this commit in the next one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regenerated with dev/regenerate_fixtures.py on ada4fa4 (clean tree) with ngraph 0.26.0, netgraph-core 0.12.0 and netlab-topogen 0.6.1, so their provenance names that commit. Results are byte-identical; only the measured step durations and the provenance records change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Git error while reading NetLab's checkout no longer aborts netlab metrics: commit and dirty are recorded as null. A pip VCS install (the documented GitHub install) records the commit pip installed, with dirty false, as 0.5.0's provenance did. The fixture regenerator refuses unless a clean tree is proven. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fixture regenerator refuses unless netlab is imported from the checkout it regenerates (an editable install), so a GitHub install's clean provenance cannot vouch for a different, dirty checkout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Update the README, metrics.md, the architecture and verification notes, the fixture and experiment READMEs and the research program to the ported code: whole units of q, sampled draws and the baseline reference, MSD alpha_feasible, TE latency from the marginal curve, run records with step durations, grouped rows and provenance. The changelog's Unreleased section lists the user-visible changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port NetLab to NetGraph 0.26.0 and NetLab-TopoGen 0.6.1 from PyPI, and release it as 0.6.0.
netlab/results.py) selects steps by name. It appliesunits_report.qonce to whole-unit bandwidth and reads the converged rows. The baseline's sampled no-failure draws count, and BAC adds one baseline reference.alpha_feasible. A null alpha fails the run withnone_feasible, never 0. NetLab refuses a placement whose demands or alpha differ from the MSD step's.step_hook, so a cache hit keeps them.combinerows keep 0.24's labels, with one row per group.The commits are kept separate so that the fixtures' provenance commit (
ada4fa4) stays onmain.Validation:
Large geography configurations and full research sweeps were not rerun.
🤖 Generated with Claude Code