Skip to content

Fix install docs and trim packaging, hooks and CI config - #4

Merged
networmix merged 1 commit into
mainfrom
housekeeping
Oct 2, 2026
Merged

networmix merged 1 commit into
mainfrom
housekeeping

Conversation

@networmix

Copy link
Copy Markdown
Owner

Documentation and repository housekeeping after #2 and #3.

  • README told users to pip install topogen, which installs an unrelated project (Cisco Modeling Labs topogen 0.2.2). Install from GitHub instead; the PyPI publish workflow is removed since the name is taken.
  • Remove eight requirements nothing imports: seaborn, rich, nbformat, nbconvert, ipykernel, itables, rasterio, scikit-learn; dev extras drop pytest-benchmark, pytest-mock and a duplicate jsonschema. Benchmark pytest flags and marker go with them.
  • Remove the isolated pre-commit Pyright hook with its hand-maintained dependency list; make lint and CI run Pyright in the project venv.
  • Add [project.urls], a specific package description, and mention the preview JPEG that generate writes.
  • CI runs on pull requests and pushes to main only, instead of twice per PR push.
  • Drop MkDocs, notebook and perf leftovers from .gitignore.

Validation: pre-commit hooks pass; Ruff, Pyright and four example schemas pass; wheel and sdist build and pass twine check; 311 tests pass with the same four known workflow-validation failures as main (pending NetGraph release).

🤖 Generated with Claude Code

The README pointed at pip install topogen, which installs an unrelated
PyPI project; install from GitHub instead. Drop eight requirements that
nothing imports, the PyPI publish workflow, the isolated pre-commit
Pyright hook, benchmark plugin flags and stale ignore rules. Add project
URLs and run CI once per PR.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T02:19:48.944772Z b92882c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@networmix
networmix merged commit f06f563 into main Oct 2, 2026
0 of 3 checks passed
@networmix
networmix deleted the housekeeping branch October 2, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant