chore: clear tsbuildinfo in clean script - #8463
Conversation
`npm run clean` removed `dist/` but left `tsconfig.build.tsbuildinfo` behind. Because `tsc --incremental` decides what to emit from that file alone rather than from what is on disk, the next `npm run build` saw an up-to-date cache and emitted nothing at all — no `dist/`, silently. Reproduced on `main`: build (1097 files) -> clean -> build (0 files). With this change the second build repopulates `dist/` as expected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Cleaning now clears TypeScript incremental build caches as documented, preventing stale cache state from suppressing rebuilt output. The change is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
commit: |
npm run cleanremovesdist/but leavestsconfig.build.tsbuildinfobehind.tsc --incrementaldecides what to emit from that file alone, not from what's actually on disk — so the nextnpm run buildsees an up-to-date cache and emits nothing. Nodist/, no error, no output.Reproduced on
maintoday:With this change the second build repopulates
dist/normally (verified: 1068 → clean → 1068).tsconfig.tsbuildinfo(from the typecheck-only project) is included for the same reason.Also updates the now-stale
npm run cleanline inCLAUDE.md.chore:rather thanfix:— dev-only script, nothing user-visible.Split out of #8453, which bundled this with unrelated work.
🤖 Generated with Claude Code