Skip to content

chore: clear tsbuildinfo in clean script - #8463

Closed
jherr wants to merge 1 commit into
mainfrom
chore/clean-tsbuildinfo
Closed

chore: clear tsbuildinfo in clean script#8463
jherr wants to merge 1 commit into
mainfrom
chore/clean-tsbuildinfo

Conversation

@jherr

@jherr jherr commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

npm run clean removes dist/ but leaves tsconfig.build.tsbuildinfo behind. tsc --incremental decides what to emit from that file alone, not from what's actually on disk — so the next npm run build sees an up-to-date cache and emits nothing. No dist/, no error, no output.

Reproduced on main today:

npm run build   # dist has 1097 files
npm run clean   # dist gone, tsconfig.build.tsbuildinfo still there
npm run build   # dist has 0 files

With this change the second build repopulates dist/ normally (verified: 1068 → clean → 1068).

tsconfig.tsbuildinfo (from the typecheck-only project) is included for the same reason.

Also updates the now-stale npm run clean line in CLAUDE.md.

chore: rather than fix: — dev-only script, nothing user-visible.


Split out of #8453, which bundled this with unrelated work.

🤖 Generated with Claude Code

`npm run clean` removed `dist/` but left `tsconfig.build.tsbuildinfo`
behind. Because `tsc --incremental` decides what to emit from that file
alone rather than from what is on disk, the next `npm run build` saw an
up-to-date cache and emitted nothing at all — no `dist/`, silently.

Reproduced on `main`: build (1097 files) -> clean -> build (0 files).
With this change the second build repopulates `dist/` as expected.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@jherr
jherr requested a review from a team as a code owner September 3, 2026 15:48
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 87d92115-09b9-4740-8068-d8512f2690e5

📥 Commits

Reviewing files that changed from the base of the PR and between 97fd77d and 7475969.

📒 Files selected for processing (2)
  • CLAUDE.md
  • package.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • The clean command now removes TypeScript build cache files in addition to the build output directory.
  • Documentation
    • Updated the development documentation to accurately describe everything removed by the clean command.

Walkthrough

The clean npm script now removes tsconfig.build.tsbuildinfo and tsconfig.tsbuildinfo in addition to dist/. The CLAUDE.md description now documents this behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 74759

Cleaning now clears TypeScript incremental build caches as documented, preventing stale cache state from suppressing rebuilt output. The change is ready to merge.

Suggested reviewers: serhalp

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the clean script change, the incremental build issue, the verification, and the documentation update.
Title check ✅ Passed The title clearly and concisely identifies the main change: removing TypeScript build-info files in the clean script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/clean-tsbuildinfo

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/netlify-cli@8463

commit: 7475969

@serhalp

serhalp commented Sep 3, 2026

Copy link
Copy Markdown
Member

@jherr I think we should just scrap incremental compilation. It isn't worth the complexity here: #8469.

@serhalp serhalp closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants