Skip to content

[NAE-2489] View only builder - #484

Merged
mazarijuraj merged 1 commit into
release/6.6.0from
NAE-2489
Oct 23, 2026
Merged

mazarijuraj merged 1 commit into
release/6.6.0from
NAE-2489

Conversation

@Retoocs

@Retoocs Retoocs commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Fix xml_text behavior to correctly save process when editing in builder tabs. It was tested manually.

Summary by CodeRabbit

  • New Features
    • XML text can now be edited in the form workflow, where it was previously hidden.
  • Updates
    • XML text is no longer included in the data shown in the view workflow. These changes clarify where XML text can be edited and where it appears, while preserving the distinct behavior of the form and view workflows.

- update xml_text behavior
@Retoocs
Retoocs requested review from Kovy95 and mazarijuraj October 23, 2026 08:14
@Retoocs Retoocs self-assigned this Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 507e678a-8220-446b-acea-0c24e653ca1b
📥 Commits

Reviewing files that changed from the base of the PR and between 3632bde and e6c9d93.

📒 Files selected for processing: 1
  • src/main/resources/petriNets/engine-processes/process.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The process definition makes xml_text editable in the form transition. It removes xml_text from the view transition.

Changes

XML field visibility

Layer / File(s) Summary
Transition field visibility
src/main/resources/petriNets/engine-processes/process.xml
The form transition makes xml_text editable. The view transition no longer includes its data reference or display settings.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e6c9d

The XML visibility changes support editing and saving processes in builder tabs without an identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the builder view behavior changed by the pull request. It is concise and related to the main objective of correcting xml_text behavior in builder tabs.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Retoocs
Retoocs marked this pull request as ready for review October 23, 2026 08:15
@mazarijuraj
mazarijuraj merged commit d7a4f8f into release/6.6.0 Oct 23, 2026
7 checks passed
@mazarijuraj
mazarijuraj deleted the NAE-2489 branch October 23, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants