Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adversarial validation (lane-A) at cd00d98Implementation matches audit-0.63.0.md Gap 1 exactly: oversized Checks at cd00d98 (CARGO_TARGET_DIR=W:\cargo-target\lane-a, jobs=4, RUST_TEST_THREADS=4): fmt pass; clippy both manifests -D warnings (3 documented pre-existing main-drift sites only, 0 in diff); rust tests 2306/0/1-ign; desktop tests 489/1 (documented #684 #711 baseline, expected). Stacked on #651 at 084719a; backend only, no UI proof required. |
Summary
Closes the remaining MiniMax half of GAP-17 (audit-0.63.0 Gap 1, partial item #6): guard the MiniMax reset-time arithmetic so an oversized reset value can never abort the refresh. The rest of steipete#3758/steipete#3764 was already covered by #585/#586.
coding_plan.rs::resets_at: build the offset withDuration::try_seconds(None for an unrepresentableremains, e.g.i64::MAXafter the >1_000_000 ms heuristic) and finish withnow.checked_add_signed; a reset that lands at/beforenowis dropped, so the usage percentage survives with no reset line.coding_plan_html.rs::parse_resets_at_from_text: "Resets in N " text with a very largeNsaturatesseconds as i64; the sametry_seconds+checked_add_signedguard turns it into no reset line instead of a panic.remains = i64::MAX, negative/zero remains, positive small/ms remains, future end-time precedence, "Resets in 99999999999999999999 days" saturation, and a normal 2-day text.Stacked on #651 (
port/micro-0.66.0-minimax-storage-discoveryat084719a8). Backend only, no UI change (a dropped reset line is the intended behavior). No new dependencies.Validation
cargo fmt --all --check: passcargo clippyboth manifests--all-targets -- -D warnings: clean except the 3 documented pre-existing main-drift sitescargo testrust manifest: 2306 passed / 0 failed / 1 ignored (minimax coding-plan focused: 19/0 incl. the new overflow tests)cargo testdesktop manifest: 489 passed / 1 failed —bootstrap_payload_exposes_every_provider_variant, the documented Isolate bootstrap payload test from real settings #684 environment-dependent baseline on branches without Make the bootstrap catalog test hermetic (#684) #711 (expected)Upstream reference
d987dd59a/70dfb8f1b; audit-0.63.0.md Gap 1. Upstream SwiftDate(timeIntervalSinceNow:)does not trap; this is the Rust analog.