Skip to content

Docs: remove retired Crof from rust/README (stacked on #610) - #728

Draft
Finesssee wants to merge 1 commit into
codex/integrate-reviewed-ports-20260923from
port/micro-0.70.0-crof-docs-retire
Draft

Finesssee wants to merge 1 commit into
codex/integrate-reviewed-ports-20260923from
port/micro-0.70.0-crof-docs-retire

Conversation

@Finesssee

Copy link
Copy Markdown
Collaborator

Summary

Stacked on #610 (base codex/integrate-reviewed-ports-20260923). Crof was retired upstream (commit 3404ae3) and #610 already removes the provider from the code and the root and localized READMEs. The only user-facing doc line still listing it on that branch was the provider list in rust/README.md; this removes it. Closes audit GAP-29.

Left alone on purpose: CHANGELOG.md and rust/CHANGELOG.md entries (history), and the retirement fixtures in rust/src/settings/tests.rs. The "40 AI providers" count in rust/README.md was already stale (the root README says 56) and is not changed here.

If #610 is merged first, retarget this PR to main. If #610 is changed to drop rust/README.md itself, this PR becomes empty and can be closed.

Tests

Docs-only; one line changed, original mixed line endings preserved. No code or UI change.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Finesssee

Copy link
Copy Markdown
Collaborator Author

Adversarial validation (Claude Opus 5.5) passed at aa295e1

Scope: GAP-29, Crof retirement in the user-facing docs.

  • The PR is one commit on top of the base head codex/integrate-reviewed-ports-20260923 (15f1091).
  • It removes "Crof," from the provider list in rust/README.md.

Checks on the change:

  • Crof is already retired in code on this base: ProviderId::from_cli_name("crof") == None, the settings migration drops it, and the icon registry test asserts it is gone.
  • After this change, the only Crof mentions left in any *.md file are historical entries in CHANGELOG.md and rust/CHANGELOG.md. Those should stay.
  • No code, wire, dependency or frontend change.

Checks run at this SHA (toolchain 1.98.0, isolated target dir):

  • cargo +1.98.0 fmt --all --check: clean.
  • cargo +1.98.0 clippy --workspace --all-targets -- -D warnings: clean.
  • cargo +1.98.0 test -p codexbar: 2235 passed, 0 failed, 1 ignored.
  • cargo +1.98.0 test -p codexbar-desktop-tauri: 477 passed, 1 failed.
    • The failing test is commands::tests::bootstrap_payload_exposes_every_provider_variant (catalog 78 vs 77).
    • The failure comes from the base and depends on the host. On this base, get_bootstrap_state() calls Settings::load(), because e8aad2a reverted the test-only Settings::default() path. The test therefore reads the local user profile, and one deprecated provider enabled there adds a catalog entry.
    • This PR only edits rust/README.md.

@Finesssee

Copy link
Copy Markdown
Collaborator Author

Adversarial validation passed at cf151f4

Scope: docs retirement of the Crof provider (#728, GAP-29), validated as merged into release/v0.70.0 (merge cf151f4 = merge of aa295e1 into 3a84269).

Attacks:

  • Scope: docs-only change (rust/README.md −1 line, removing Crof from the provider list). Docs were audited against the merged tree: zero remaining "Crof" mentions in rust/README.md and no other user-facing README referencing the retired provider, matching the audit's GAP-29 retirement note.
  • Adjacent code risk: none — the change is documentation-only, no production behavior, no test impact, no bridge/locale impact. The browser-use proof is n/a (docs), matching the audit's ui column.
  • Locale/bridge check: the audit's Crof retirement tracking (GAP-29) sits with the 0.64.1-eraCrof removal; the merged release branch has no lingering Crof-specific settings or provider paths the README could contradict.

No defects found. READY for the un-draft rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant