Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed by Codex gpt-6-luna (xhigh); verified and validated by Claude Thermo-nuclear review of PR #680 against the dashboard-usage-display spec (0.68.0). No source-code findings: behavior, tests, accessibility label, provider siloing and the unchanged bridge contract match the spec; no locale keys apply to this standalone English dashboard page. No code changes made, nothing pushed. Left open (1, S3, not a code defect): the spec asks for 1280 px and 390 px screenshots and the PR notes they were not captured. They need a real rendered page, which this workflow does not produce (the app and browsers are not launched here); to be collected as UI proof by the coordinator. |
Adversarial validation (lane-B review)Head validated: Verdict: no blocking defects. Spec conformance verified at head:
Validation re-run at head (pinned 1.98.0, E-cores): |
Summary
The
codexbar servedashboard page gets a header "Usage display" control (Follow server,Used,Remaining).Follow serverkeeps the current behavior (host.usageBarsShowUsed);Used/Remainingoverride it for this browser.localStorage["codexbar.dashboard.usageDisplay"]. Onlyusedandremainingare accepted; anything else, a throwinggetItem, or unavailable storage yieldsserver. Choosingserverremoves the key. Storage errors are swallowed and the selection still applies to the page.usedPercent: 70 warn, 90 full). Before,pctClassreceived the displayed value, so 95% left rendered red. The label and bar width still follow the displayed value.hostorremainingPercentstill default to remaining, deriving100 - usedPercent.state.snapshotwas assigned after rows were built, so rows read the previous snapshot'shostpreference. It is now assigned before rendering.Upstream reference
Sources/CodexBarCLI/CLIServeWebUI+HTML.swift(usageDisplayKey,storedUsageDisplay(),changeUsageDisplay(),renderWindow).rust/src/cli/serve/dashboard/dashboard.html,html.rs,docs/CLI.md.Ported / Deferred
worstWindowLevelprovider/account pill is not ported. The local dashboard has no such pill (its chip shows provider status), so there is nothing to change; severity for the bars is covered.Validation
cargo +1.98.0 fmt --all: cleancargo +1.98.0 clippy --workspace --all-targets -- -D warnings: passcargo +1.98.0 test -p codexbar dashboard::html -- --test-threads=4: 14 passed (7 new)cargo +1.98.0 test -p codexbar cli::serve -- --test-threads=4: 121 passedserver;used/remainingswitch label, width, and class without refetch; 95% left rendersbarand 5% left rendersbar fullin remaining mode; a throwing storage still applies the selection.flex-wrapso the new control wraps at narrow widths.Affected areas
codexbar servedashboard page)docs/CLI.md)UI proof
Not applicable for CUA (served web page, not a desktop surface). Pending: coordinator may capture a browser screenshot at 1280 px and 390 px.