Port upstream 0.66.0: Atlas Cloud typed balance and parity (stacked on #618)

[Finesssee]

Summary

Closes the parity gaps between Atlas Cloud in #618 and upstream 0.66.0:

• Balance is now a typed USD CostSnapshot (with_balance), so it reaches balance formatting, Usage & Spend, and currency conversion. It was an untyped display string without a $.
• A signed display row "Available balance" ($95.50, $0.00, -$1.25) is kept alongside the typed value, because CostSnapshot::with_balance clamps to >= 0 and upstream preserves zero and negative balances (see the correction comment on Port Atlas Cloud balance provider from v0.66.0 #618).
• Identity login method is API, as upstream sets identity.loginMethod = "API".
• One canonical dashboard URL, https://www.atlascloud.ai/console. settings::api_keys now reads atlascloud::DASHBOARD_URL instead of carrying a second, disagreeing literal.
• Upstream ProviderIcon-atlascloud.svg glyph added to the frontend icon registry (fill switched from #000 to currentColor so it tints with the brand color on the dark UI).

No wire-shape change: the endpoint, envelope checks, and status mapping are unchanged.

Upstream reference

• Release bullet: "Atlas Cloud: show account-wide available USD balance through the documented API-key endpoint (Add support for Atlas Cloud API steipete/CodexBar#2714)" (5cfe3f1f, feat(providers): add Atlas Cloud and Vercel balance plugins steipete/CodexBar#3917), v0.66.0.
• Tag-pinned files: Sources/CodexBarCore/Resources/Plugins/atlascloud.js (row "Available balance" via ctx.format.usd, identity.loginMethod = "API"), Sources/CodexBarCore/Providers/AtlasCloud/AtlasCloudProviderDescriptor.swift (dashboardURL), Sources/CodexBar/Resources/ProviderIcon-atlascloud.svg, Tests/CodexBarTests/APIBalancePluginTests.swift (zero and negative balances preserved).

Ported / Deferred

Ported: typed balance, signed display row, login method, single dashboard URL, frontend icon, tests for "-1.250000", "0.00", "", " ", NaN, 1e999, 0x10, "private-response", wrong object/scope/currency, and HTTP 400/401/403/429/503 without echoing the body.

Deferred:

• docs/logos/atlascloud.svg and the embedded serve-dashboard icon (rust/src/cli/serve/dashboard/icons/): that table is pinned to the v0.48.0 white-glyph set and upstream's Atlas glyph is black, so the colour treatment needs a separate decision. The dashboard falls back to its neutral dot meanwhile.
• Locale keys: no provider-specific UI strings were added, so there is nothing to translate.
• Retry-After handling: upstream only forwards it as metadata and does not opt into retryPolicy, so nothing to port.

Validation

• cargo +1.98.0 fmt --all: clean
• cargo +1.98.0 clippy --workspace --all-targets -- -D warnings: pass
• cargo +1.98.0 test -p codexbar atlascloud -- --test-threads=4: 11 passed
• cargo +1.98.0 test -p codexbar -- --test-threads=4 (full): 2275 passed, 0 failed, 1 ignored
• pnpm exec vitest run providerIcons.test.ts TrayPanel.test.tsx: 31 passed
• pnpm run lint: pre-existing warnings only; pnpm run build: pass

Affected areas

• Provider backend (rust/src/providers/atlascloud)
• Settings API-key catalog (dashboard URL only)
• Frontend icon registry (glyph asset only, no component change)
• Tray / settings / float bar behavior

UI proof

Pending: coordinator will capture CUA proof on a fresh build (tray card balance row and Atlas icon). Triage classed this port as not UI-affecting; the only visible change is the icon glyph and the $ balance text.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b863c52e-253d-407f-a910-6603219dadf4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Finesssee]

Reviewed by Codex gpt-6-luna (xhigh); verified and validated by Claude

Thermo-nuclear review of PR #676 against the atlas-cloud-parity spec (0.66.0). Typed USD balance, login method, canonical dashboard URL, icon, parsing/status tests, siloing and bridge contracts are covered. Findings (3):

• Medium MenuCardDetails.tsx:598 - provider display details were rendered twice in detailed mode (a second block lacked the compactOverview guard, so they also showed in compact overview). Fixed: removed the duplicate block, added a regression test.
• Medium CostSection.tsx:16 - a balance-only snapshot's required used = 0 showed as "$0.00" spent in provider settings. Fixed: the cost section omits balance-only snapshots; the balance shows in the provider detail row. Test added.
• Low providerLabels.ts:7 - the Atlas Cloud balance row title and cost heading bypassed localization. Fixed: new locale keys AtlasCloudAvailableBalance / AtlasCloudBalance in all eight locales, keys.ts and locale.rs, wired through a small providerLabels helper for tray and settings.

[Finesssee]

Fixes landed at the head of this branch (3 of 3 findings fixed, none left).

Commands run: cargo +1.98.0 fmt --all --check; cargo +1.98.0 clippy --all-targets -- -D warnings on both manifests (clean); cargo +1.98.0 test --manifest-path rust/Cargo.toml locale (16 passed); pnpm test (70 files, 412 tests passed); pnpm run build (tsc + vite OK). CUA proof not run (the desktop app must not be launched in this workflow); UI proof to be collected by the coordinator.

[Finesssee]

Adversarial validation (lane-A) at 8926a75

The parity amend (7522ae14) absorbed the finished #620 chain (4663218: build_fetch_context fix from the #619 merge) without conflict. Review of the 676 diff against the 0.66.0 audit row 1a residual: typed USD balance cost row (-$1.25 / $95.50 signed formatting, zero preserved), login method "API", one canonical dashboard URL shared by the tray and the metadata link, upstream icon SVG registered in the icon catalog and the tray HAS_DASHBOARD switch. Tests cover zero, negative, and positive balance paths plus URL stability. No new dependencies; behavior aligns with the audit's "typed balance + icon + single URL" spec.

Checks at 8926a75 (same environment as the #618 comment): fmt pass; clippy both manifests -D warnings clean except the 3 documented pre-existing main-drift sites; rust tests 2297/0/1-ign; desktop tests 489/1 (documented #684 baseline, expected without #711); vitest 34 passed for the touched frontend files.

Fast-forward pushed 4001969f..8926a75d (the merge commit 8926a75d carries the #620-chain absorb).

[Finesssee]

Adversarial validation passed at 8926a75

Scope: Atlas Cloud typed balance and parity — provider labels fold-in (#676, upstream 0.66.0), validated as merged into release/v0.70.0 (merge 8926a75 = merge of 4663218 into 4001969; the audit's "content via 618" note refers to this merge carrying the parity content through the Atlas chain).

Attacks (highest-risk semantics, from the merged tree):

• Typed balance + provider labels both survive the chain: the Atlas chain integrates in order Add provider-specific token account routing #620 → Port upstream 0.66.0: Atlas Cloud typed balance and parity (stacked on #618) #676 (parity/labels) → Port Atlas Cloud balance provider from v0.66.0 #618 (typed balance); the merged b49dc2b tree carries the atlascloud provider module (+226 lines), its test module (+245), and the api_keys catalog entry (+11), so the label/parity content was not displaced by the later typed-balance work.
• Factory arm completeness: providers/mod.rs (+2) and the exhaustive factory mean the Atlas Cloud arm is compile-checked; a missing arm or a duplicate registration would fail the build, not slip through review.
• Locale keys: the merged tree carries the atlascloud keys across locales (zh-TW and the other 7), so the settings surface cannot render raw key text.
• Scope discipline: the parity work (typed balance, signed display row, strict parsing) is validated in detail in the Port Atlas Cloud balance provider from v0.66.0 #618 pass at b49dc2b; this pass confirms the Port upstream 0.66.0: Atlas Cloud typed balance and parity (stacked on #618) #676 fold-in content (labels, registration, settings) is present and intact in the merged chain.

No defects found. READY for the un-draft rule.