Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CUA UI proof (local, fresh build)
Assertions
Local artifacts (not committed), all under
|
|
Reviewed by Codex gpt-6-luna (xhigh); verified and validated by Claude Thermo-nuclear review of PR #657 (2 findings, both fixed):
|
|
Fixes pushed at 9170b79: both findings fixed, none left. Validated with cargo +1.98.0 fmt --all; clippy --workspace --all-targets -D warnings (clean); cargo test -p codexbar render (23 passed); cargo test -p codexbar-desktop-tauri usage_metric (18 passed). CLI output unchanged; companion-window dedupe now differs only when the detail flag differs. CUA proof not re-run. |
UI proof (browser-use)Fresh proof at the CURRENT PR head 9170b79 (the earlier CUA proof Build: debug desktop exe at 9170b79 with the proof-only dirs shim and three proof-only overlays
Known seed artifacts (not PR behavior): "Updated 26526d" (2099 seed date), "Data Source: seed". Screenshots (local, not committed): Coordination note: the proof ran under the proof.lock (both port-audit paths, owner=worker) with |
|
Validated 2026-10-02 at 9170b79 (current PR head, includes the "Address thermo review" fixes):
Chain status: READY for the integrator — merge #647 first, then #657; that unblocks #702 (LiteLLM identity/budgets) and the Mistral 0.70 pair #717/#718, which are stacked on this head. |
…ets, private-network HTTP (stacked on #657)
…riptionFallback for the hook fallback slot, gate informational windows, keep detail lines out of reset wording
Summary
For Mistral, the amounts string carried in
reset_description(the Included API window and the extramistral-monthly-plan"Monthly Plan" window) is now treated as a detail line and never as a reset time.resets_atexists, then the amounts line. JSON output is unchanged (the new flag is not serialized).normalizeResetDescription. WhenresetsAtis absent, no reset text is shown.RateWindow.description_is_detail(skip_serializing), set only by the Mistral provider.Stacked on #647.
Upstream reference
Upstream 0.68.0:
CLIRenderer.appendResetAndDetailLines,MenuDescriptor.appendRateWindow(descriptionIsDetail:), and the Mistral descriptor (usesDetailBackedWindow,extraRateWindowUsesResetDescriptionAsDetail,primaryDescriptionIsDetail), plusMistralCLIOutputTests/MenuDescriptorMistralTests. Read-only, tag-pinned reads.Ported / Deferred
Ported:
RateWindow.description_is_detailflag pluswith_description_as_detail()builder (rust/src/core/rate_window.rs).descriptionIsDetail, tray compact reset label guard.resetDescriptionFallback/windowDetailTexthelpers, MenuCardDetails, UsageSection, FloatBar, CSS.Deferred: none for this item.
Validation
cargo +1.98.0 fmt --all: cleancargo +1.98.0 clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings: cleancargo +1.98.0 clippy --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml --all-targets -- -D warnings: cleancargo +1.98.0 test --manifest-path rust/Cargo.toml -- --test-threads=4: 2169 passed, 0 failed, 1 ignoredcargo +1.98.0 test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml -- --test-threads=4: 463 passed, 1 failed. The failure iscommands::tests::bootstrap_payload_exposes_every_provider_variant(catalog size drift, 79 vs 78). This diff does not touchProviderIdor the catalog, and the test reads machine-local state; it is not caused by this change.pnpm --dir apps/desktop-tauri exec vitest run: 67 files, 410 tests passedpnpm --dir apps/desktop-tauri run lint: no errors (existing warnings only)pnpm --dir apps/desktop-tauri run build: passed (tsc + vite + locale drift check)New tests: CLI text (reset then amounts, no reset line without a date, flag absent from JSON), tray compact-label guard in
status.rs, and Vitest cases for MenuCard, UsageSection, FloatBar andusageWindows.Affected areas
Mistral usage display in CLI text, tray card, Settings Usage section, float bar and tray compact reset label.
RateWindowSnapshotbridge DTO gains an optionaldescriptionIsDetail. No settings, dependency, or wire-format changes.UI proof
Pending: coordinator will capture CUA proof on a fresh build.