Skip to content

fix(kubernetes-tilt-dev): upgrade NestJS sample to v12 - #429

Merged
ulises-jeremias merged 1 commit into
mainfrom
fix/devops-reference-nestjs-12-security
Oct 5, 2026
Merged

ulises-jeremias merged 1 commit into
mainfrom
fix/devops-reference-nestjs-12-security

Conversation

@ulises-jeremias

@ulises-jeremias ulises-jeremias commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Description

Upgrade the Kubernetes Tilt DevOps example from NestJS 11 to NestJS 12 and TypeScript 6. NestJS 12's Swagger package upgrades js-yaml to a patched release, resolving Dependabot issue #427. Update the runtime/toolchain to Node.js 24, configure TypeScript for NestJS 12's ESM packages, and run Jest with Node's VM modules support.

Fixes #427

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Using Node.js 24.21.0 after a clean npm ci:

  • npm run type-check
  • npm run build
  • npm test -- --runInBand
  • npm run test:e2e -- --runInBand
  • npm run lint
  • npm audit --audit-level=low (0 vulnerabilities)
  • git diff --check

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Guides and Examples

  • Back-reference exists.
  • Registered in examples.json. Existing example; no registration change required.
  • Links resolve.
  • Sanitized.
  • No unsafe examples.

Summary by CodeRabbit

  • Updates

    • The NestJS Kubernetes example now uses Node.js 24, NestJS 12, and TypeScript 6.
    • Updated TypeScript configuration and test commands to support the newer toolchain.
  • Documentation

    • Updated the quickstart with Node.js version requirements for setup and running tests, plus guidance for switching to the pinned version.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3878297a-a1af-4aa7-a430-2fac1c77270a
📥 Commits

Reviewing files that changed from the base of the PR and between 4f4b054 and 32d8a12.

⛔ Files ignored due to path filters (1)
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (8)
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/.eslintignore
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/.gitignore
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/.node-version
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/Dockerfile
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/README.md
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/package.json
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/tsconfig.build.json
  • examples/kubernetes-tilt-dev/apps/node-nestjs-app/tsconfig.json
 _________________________________________________________________________________________
< The three laws of code review: 1. Find bugs. 2. Find more bugs. 3. Find even more bugs. >
 -----------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Messages
📖 Thanks for updating docs! We ❤️ documentation!
📖 Thanks! We ❤️ small PRs!

Generated by 🚫 dangerJS against 32d8a12

@ulises-jeremias
ulises-jeremias merged commit b160692 into main Oct 5, 2026
19 of 20 checks passed
@ulises-jeremias
ulises-jeremias deleted the fix/devops-reference-nestjs-12-security branch October 5, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security: track js-yaml advisory in NestJS example

1 participant