Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Seven links into the docs site (README, SECURITY.md, the engine and SDK READMEs) now go through
/latest/, and a test keeps new ones from skipping the version.Why
The docs site is versioned with mike: pages live under
/nl2sql/<version>/, and only the front page redirects tolatest. Links such ashttps://nadeem4.github.io/nl2sql/get-started/demo/return 404, including on the PyPI project pages (fixed there at the next release).How to test
pytest packages/nl2sql/tests/unit/test_docs_site_links.py -qfails on main and passes here. Every changed URL returns 200 on the live site.Checklist