Repository navigation
Queue agent and auxiliary deploys instead of cancelling a running one - #1700
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #1699 agent deploy was cancelled when #1698 and #1699 merged five seconds apart. The
deployjob uses the concurrency groupagent-deploywithcancel-in-progress: true, so whichever deploy started second cancelled the one already running. Here the cancelled deploy was the newer commit's (run 40069255269).Each deploy does a rolling replace that pulls
:main. A running deploy should finish, and the newest pending one should run after it. Withcancel-in-progress: false, GitHub still drops older pending runs in the group, so the most recent commit is always the last one deployed.auxiliary-deploygets the same change.