Repository navigation
Promote the Android audio service before building sources and retry refused starts on resume - #1696
Merged
Merged
Conversation
…efused starts on resume
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chat_panel.dart:findChildIndexCallbacklooks keys up in a map built once alongsidekeysinstead of a linear scan that allocated aKeyper comparison (O(n²) when a long list shifts).uniqueKeystracks the next suffix per repeated key instead of retrying from#1each time. Suffixes are still numbered from the oldest, so keys stay stable as messages arrive.emote.dart: only the backend call is retried; JSON/fromJsonerrors can't succeed on retry, so they're reported right away and the cache is used. The test-onlyretryDelay/reportErrorparameters are replaced by@visibleForTestingtop-levelemoteRetryDelay/reportEmoteError.emote.dart: concurrentgetEmotescalls for the same channel as the same signed-in user (the chat and the message input both fetch on channel open) share one in-flight fetch, so on a cold cache they don't both call the backend and write the cache file at the same time. The in-flight key and the disk cache are scoped by Firebase Auth uid (oranon), since Twitch emotes depend on who's signed in.views.dart: removed thedefaultChannelsalias and_channelsFromJson, inlining both into their single uses. Tests now checkchannels.channelsno longer re-wraps the already-unmodifiable_channels.stream_preview.dart: checkmounted/_isTwitchafter the 2s quality delays before running JS, and cancel_overlayTimerindispose.main.dart:isFatalFlutterErrortreatsdetails.silenterrors as non-fatal, andFlutterError.onErroris a singlerecordFlutterError(details, fatal: ...)call.flutter analyzeis clean andflutter testpasses (470 tests).AudioModelruns syncs one at a time (coalescing queued ones), so an older sync still awaiting the permission check can't land after a newer clear.stopSelfResult(startId)and only drops foreground state when that succeeds, so clearing can't cancel a newer queued start.