Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130.
A large inline image (
<img src="data:image/png;base64,...">) inside an element converted with a lazy pattern, such as<li>(.*?)</li>or<a ...>(.*?)</a>, exhausts the PCRE backtrack limit.preg_replace()then returnsnull, andgetText()silently returns an empty string, with only deprecation notices frompreg_replace_callback()andstrip_tags().The image source is never part of the text output, so
doConvert()now emptiesdata:URIs inimg srcattributes before the conversion. It uses a possessive pattern, so this step itself runs in linear time. Alt text is still rendered as before.DataUriTestcovers a 1.3 MB image in a list item, in a link and in a paragraph. The list item and link cases return an empty string on master.