Repository navigation
Return positions from every section in indexed allGeneratedPositionsFor - #565
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IndexedSourceMapConsumer.prototype.allGeneratedPositionsForreturns positions from the first section that contains the requested source only. When the same original source appears in several sections, positions in the later sections are missing.This change queries every section that contains the source and concatenates the results in section order. The per-section offset handling moves unchanged into a private
_sectionGeneratedPositionsForhelper. Each section keeps the existing lookup rules ofBasicSourceMapConsumer.prototype.allGeneratedPositionsFor.generatedPositionForis unchanged, because it returns a single position.Fixes #564
Testing
test allGeneratedPositionsFor for index map with a source in several sectionsintest/test-source-map-consumer.js. It fails without the change inlib/source-map-consumer.jsand passes with it.npm test: 191 / 191 tests passed.eslintandprettier --check .report no issues.