Add GitHub Actions CI workflow for lint and tests (#79) - #447
Draft
stephaniehobson wants to merge 5 commits into
Draft
stephaniehobson wants to merge 5 commits into
stephaniehobson wants to merge 5 commits into
Conversation
stephaniehobson
added this pull request to stack #445
September 18, 2026 23:32
stephaniehobson
changed the title
stephaniehobson
marked this pull request as draft
September 18, 2026 23:39
stephaniehobson
force-pushed
the
79--github-actions-ci
branch
4 times, most recently
from
September 21, 2026 17:40
5831bff to
f846c70
Compare
stephaniehobson
force-pushed
the
79--github-actions-ci
branch
3 times, most recently
from
September 21, 2026 18:51
9a3ca39 to
47c0806
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Blocking E2E checks depend on live third-party URLs, and the ExecPlan contains stale records and a missing revision note.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (6)
| - name: "Install Playwright browsers" | ||
| run: npx playwright install --with-deps chromium | ||
| - name: "Run end-to-end tests" | ||
| run: npm run test:playwright |
Comment on lines
+321
to
+325
| than smoothed over: two of these specs (`contact.spec.js`'s "All links work", | ||
| `footer.spec.js`'s "All footer links work") check real, live external URLs and have, in the past | ||
| (documented in PR #444's own `docs/execplans/2026-09-15-update-toolchain.md`), failed for reasons | ||
| external to this repository — a dead forum link, a redirect target that blocks non-browser HTTP | ||
| clients. Both passed cleanly in this session's own run. If either becomes a recurring source of a |
stephaniehobson
force-pushed
the
79--github-actions-ci
branch
2 times, most recently
from
September 22, 2026 17:52
f2ad5c9 to
b224c69
Compare
The final jump in this string of redirects blocks bots so we'll back up one step and test that the redirect is configured (that we get a 301) and not test the entire redirect path. Just for this link.
stephaniehobson
force-pushed
the
79--github-actions-ci
branch
from
September 22, 2026 17:55
b224c69 to
53cce11
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs lint (ESLint + stylint), the Vitest unit suite, and the full Playwright end-to-end suite on every push to main and every pull request, via a single "CI" workflow with two jobs.
Based on springfield where possible.