feat(get-modflow): consistently retry transient network failures - #2849
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2849 +/- ##
===========================================
+ Coverage 55.5% 73.6% +18.1%
===========================================
Files 644 659 +15
Lines 124135 132370 +8235
===========================================
+ Hits 68947 97550 +28603
+ Misses 55188 34820 -20368
🚀 New features to boost your workflow:
|
wpbonelli
changed the title
flopy.utils.get_modflow is bound to run_main, so monkeypatching module attributes (http_retry_delay, urlopen, ...) raised AttributeError at fixture setup, erroring every test in the file. Import get_modflow_module instead, and pull in run_main for test_python_api. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZ9JZKVxBAWym16KcgQoU
wpbonelli
marked this pull request as ready for review
September 10, 2026 11:48
mwtoews
approved these changes
Sep 14, 2026
mwtoews
left a comment
mwtoews
left a comment
Contributor
There was a problem hiding this comment.
Looks like a good strategy around transient network issues. Also, surprisingly still works with Python 3.6 as a stand-alone script!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a consistent, configurable retry mechanism for all three network calls
Previously the download didn't retry, just the first two queries