Repository navigation
Fix client transport leak on reconnect - #614
Open
Adebayo120 wants to merge 1 commit into
Open
Adebayo120 wants to merge 1 commit into
Adebayo120 wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adebayo120
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
October 24, 2026 11:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connect().disconnect()closes the replacement.Reproduction
Connect one
Clientto a first transport, callconnect()again with a second transport, then calldisconnect(). Before this change, the first transport'sclose()is never called; only the second transport is closed, potentially leaving the old server process or HTTP session/stream active.Validation
php vendor/bin/phpunit tests/Unit/Client(803 tests)