Repository navigation
Fix parallel integration test server startup - #1982
Open
jeffhandley wants to merge 1 commit into
Open
jeffhandley wants to merge 1 commit into
jeffhandley wants to merge 1 commit into
Conversation
Launch pinned npm test servers directly with node instead of npx to avoid shared-cache races. Add concurrent startup coverage and document installation prerequisites. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 31750ec3-6eef-4c89-bf64-2bd317a692d9
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launch the pinned Everything and Memory integration-test servers directly with
nodeinstead of invokingnpxfor each connection. This avoids npm installation and shared-cache access during parallel server startup, addressing the Windows startup race.node_modules, with an actionable error when dependencies are missing.npm ciprerequisite and how to link a built local Everything server without changing the test arguments.The existing Build and Test workflow already sets up Node 22 and runs
npm cibefore testing; no CI workflow changes are required.Validation
ModelContextProtocol.Testswith zero warnings and errors.ClientIntegrationTestson .NET 10, .NET 9, .NET 8, and .NET Framework 4.7.2: 61 passed and 2 skipped per framework, with no failures.Note
This pull request description was generated by GitHub Copilot.