Repository navigation
A recording names what map named: quoted locators, and text for a page element with no id (CHALLENGES 314) - #207
Merged
Merged
Conversation
…ement with no id gets its text as a locator, not a ref (CHALLENGES 314)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the two leads written into ROADMAP's "A recording as code" (#202). Both were confirmed in the code, then fixed.
Checked in Safari on the iPhone 17 Pro simulator:
The inspector guide gets a dated note. Its 2026-09-29 example is real output, so it is left as it is. New unit tests: `TestARecordedLocatorKeepsItsQuotes` and `TestAPageElementWithNoIDGetsALocator`. `make ci` passes.