Repository navigation
An Apple TV's alert is answered by its remote, whichever way was asked (CHALLENGES 313) - #206
Merged
Merged
Conversation
…d: a dialog of three no longer names button, which taps (CHALLENGES 313)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an Apple TV, a dialog of three or more buttons was refused naming `app_alert` with `button` as the remedy. `button` presses by tapping, and a TV refuses every tap, so the remedy led to a second refusal. A two-button dialog was already right: accept and dismiss were refused naming the D-pad (CHALLENGES 298).
The fix: `app_alert` asks the driver (`mobiumdriver.AlertAnsweredByRemote`) before it chooses between accept, dismiss and a button. On a TV, all three are refused with the same D-pad instructions, and the dialog's buttons go in the details. `app_alert`'s schema and `mobium alert --help` no longer say `button` works "on any dialog".
Checked: