Repository navigation
wait --for visible means on screen: an off-screen row is not visible (CHALLENGES 311) - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`wait --for visible` kept any match with a size. iOS keeps a list's rows off screen in the tree with real bounds, so a row thousands of pixels below the screen was "visible". Visible and hidden now ask whether the element's center is on the screen and inside the part of its list in view.
Measured on MobiumApp's Table Demo on the iPhone 17 Pro simulator: Item 25, at y 5307, is refused as visible ("off screen — app_scroll_to brings it into view"), passes as hidden, and is visible after `scroll-to`.