Repository navigation
scroll-to: up past the start pulls at most once and says it may have refreshed (CHALLENGES 310) - #201
Merged
Merged
Conversation
…refreshed (CHALLENGES 310) At the start of a list the swipe that proves the end is a pull: from a fed list sixty rows deep, a search up refreshed MobiumApp's Feed twice on the iPhone and the simulator and once on the Android emulator, losing the rows, and said only "the end of the list". The loop now stops at the start once a swipe moved the rows clearly less than the one before, the first row whole at the edge; a busy indicator that came and went with nothing new is not more rows; and a search that reaches the start says the last swipe may have been answered by a refresh, in text and details. Measured: simulator no refresh and rows kept; iPhone one pull, from two; emulator one, which the swipe reaching the start makes there. feed.sh asserts it on all three.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scroll loop ends a list with a swipe that moves nothing, and at the start of a list that swipe is a pull. On MobiumApp's Feed Demo, with pull to refresh added in mobiumdev/mobium-app#27, an upward search from Row 45, with sixty rows loaded, refreshed the feed and threw the loaded rows away. It said only "the end of the list".
What changed
may_have_refreshedin the details. Whether the app refreshed can't be read from outside, so it's worded as a possibility.Measured (from Row 45, swipes / refreshes, before → after):
On the iPhone and the emulator, the swipe that reaches the start already pulls: 3 out of 3 on the emulator, from 300 px down. Nothing short of knowing where a list starts could avoid that one, and it's now reported.
Checks
feed.shasserts the warning and at most one pull per search. It passed on all four devices.make ci: 232 checks, 0 failed.