Repository navigation
Add bring-your-own encoder functions to GPU contexts - #504
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
SSAO synchronization and staging-belt lifecycle documentation need correction.
2 open findings
What changed in this PR
Adds caller-provided command encoder support to GPU rendering pipelines.
Changes:
- Adds low-level
encodeAPIs using staging belts. - Refactors submission methods around the new APIs.
- Documents usage and lifecycle requirements.
| File | Description |
|---|---|
fidget-wgpu/src/voxel/mod.rs |
Adds voxel encoding support. |
fidget-wgpu/src/voxel/effects/mod.rs |
Adds encoder-based voxel effects. |
fidget-wgpu/src/pixel/mod.rs |
Adds pixel encoding support. |
fidget-wgpu/src/pixel/effects/mod.rs |
Adds encoder-based pixel effects. |
fidget-wgpu/src/lib.rs |
Documents encoding APIs. |
fidget-wgpu/src/color.rs |
Converts color uploads to staged copies. |
fidget-wgpu/src/buf.rs |
Adds staged config-buffer writes. |
CHANGELOG.md |
Records the new APIs. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| .unwrap(); | ||
| writer.copy_from_slice(cfg.as_bytes()); | ||
| } | ||
| compute_pass.set_pipeline(&self.blur_pipeline); |
Owner
Author
There was a problem hiding this comment.
This is incorrect; WebGPU handles this kind of synchronization internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us integrate into rendering pipelines where we're only given a
CommandEncoderand don't want to submit work to the GPU queue behind its back.