Repository navigation
Pin h5p-author 0.10.0, and serve its skill only as zips - #52
Merged
Merged
Conversation
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
View guided diff | Turn on auto-fix | Re-trigger cubic
… served one by one
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51.
h5p-author 0.10.0 (missing-elements/h5p-toolkit#203) changes the skill, not how a package is built. With it, the site stops serving the skill's text files one by one: the zips carry them (the owner's call).
The 0.10.0 skill has each build route as a file of its own under
references/build/. A chat that built nothing writes a page that makes the build page's link. Only the content type is asked, and the author and licence rule now sits in every type file's generated text.What changes
package.jsonand the lockfile move@missing-elements/h5p-authorfrom 0.9.8 to 0.10.0. The lockfile change is the five lines of that entry, with the integrity npm gives for 0.10.0. Its dependencies are the same as 0.9.8's./h5p/skill/h5p-author.zipand/h5p/skill/h5p-author-chatgpt.ziphold 0.10.0's skill, the five route files included, and the plugin'splugin.jsonsays 0.10.0. These are what the guide's first step hands out./h5p/skill/serves the zips and its page, nothing else:SKILL.md,LICENSE,references/andindex.json, which listed them, are gone.eleventy.config.jsno longer copies the files,src/_data/skill.jsno longer lists them, andsrc/h5p/skill/index.json.11ty.jsis deleted./h5p/skill/: it lists the two zips and thenpx skills addcommand, then the build tool and every bundle, each at its full address, as before. It stays because the skill's route 3 takes the bundles' addresses from it, and so do installed copies of 0.9.x. Its "for a person" note points to the guide's install step and the build page.SKILL.mdand the type files at/h5p/skill/, and so were prompts copied before 2026-11-13. They now find nothing there. Installed copies build as before: they take only the bundles' addresses from the page./h5p/skill/and its pins table;vite.config.ts' header andskillZips(); the sitemap's comment./h5p/build/types/carries 0.10.0's 32 type files, whose generated text names the licence codes./h5p/bundles/index.jsonsays author 0.10.0, with the same bundles from pack 1.1.0.h5p-author-build.tar.gzholds 0.10.0's tool.Tested
pnpm install --frozen-lockfile,pnpm build(which type-checks) andpnpm typecheckpass. The build's own check that the tool's--versionnames the pinned author and pack versions passed._site/writes three files under/h5p/skill/:index.htmland the two zips. Each zip's 40 skill files (SKILL.md,LICENSEand the 38 underreferences/, the five route files among them) equal the published 0.10.0 tarball's, and the 32 type files under/h5p/build/types/equal its too. No page or JSON file in the built site names 0.9.8./h5p/skill/and/h5p/bundles/that the built pages name resolve to a file, and nothing in the site or the built pages namesskill/SKILL.md,skill/referencesorskill/index.json.h5p-author.mjs --versionprints 0.10.0 and pack 1.1.0, and it built a True/False with--libraries partsthat the verifier passes. A build from npm's 0.10.0 gave the same revision.Summary by cubic
Pins
@missing-elements/h5p-authorfrom 0.9.8 to 0.10.0, closing #51, and serves the skill only as zips. 0.10.0 changes the skill, not how a package is built: each build route is now a file underreferences/build/, and the author and licence rule live in each type file's generated text.What changes
/h5p/skill/: the page lists the two zips and the bundles' addresses instead, and the passthrough copy ofSKILL.md,LICENSEandreferences/, plusindex.json, were removed.package.json, the lockfile,README.mdand the skill's page name 0.10.0; no page or file names 0.9.8.Written for commit 86a604e. Summary will update on new commits.