Repository navigation
feat(verify): warn of a video or a recording the browser could not play (#218) - #229
Merged
Merged
Conversation
…ay (#218) After the settle, each <video> and <audio> in the frame with a MediaError is a warning: the content plays, but that part does not, which only the screenshot showed before. Where the browser plays no H.264 at all, an mp4's failure is "not checked" rather than the file's fault. The h5p-verify skill's table says what each means and what to do. Part of #218, item 3.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
- A media path with an escape that is not one, %zz, is named as written; before, it threw in the frame and every media warning was lost. - An m4v counts with mp4 and m4a; a recording is "not checked" where the browser plays no AAC, a video where it plays no H.264. - README: "a video or audio"; the skill's row names both, Haiku-checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #218: item 3. With #228, items 1 and 2, this is step 4 of #219's plan.
What changes
<video>and<audio>in the frame with aMediaErroris named by its path in the package, with what the error says:warning: video does not play: videos/big-buck-bunny.mp4: it is no format this browser playsBefore, h5p-author: a source with media can build, pass the verifier and not play: check a video's and a recording's bytes #218's package, an Interactive Video whose mp4 was a wiki's web page, passed with nothing said. Only its screenshot showed "Video format not supported."
video not checked: … this browser plays no H.264; Chrome or Edge does, instead of blaming the file. Playwright's own browser is now Chrome for Testing, which plays both, so this is for a--browserwithout them.%zz, is named as written.design/verify.mdgets its rule once the owner's uncommitted edit of that file is in, to avoid a conflict.Testing
odd%zz.mp4is named as written. All the others pass unchanged.--browser.Release
In verify 1.6.0, with #227's exports.
Summary by cubic
Warns when the browser can't play a video or recording in a verified package, instead of passing silently.
<video>and<audio>in the frame with aMediaErrorbecomes a warning naming the file by its path in the package and what the error says; a name like%zzthat is not a real escape is shown as written rather than losing the whole media warning. The rest of the content still plays.Written for commit 05805be. Summary will update on new commits.