Repository navigation
Grammar coverage: gapped relatives, inverted dative subjects, -andi agent nouns - #72
Merged
Merged
Conversation
Constructions that failed to parse or got the wrong tree:
- "kerfis sem til stendur að innleiða á næsta ári": relative clauses
whose gap is the object of an infinitive after impersonal 'til
stendur' / 'stendur til' (new alternatives in SetningAukafallÁnF).
- "kerfinu sem við ætlum að innleiða": relative clauses with a subject,
a verb taking an infinitive and the infinitive's object gapped. New
nonterminal SagnRunaStýfðNh under SagnRunaStýfð covers control verbs
with 'að' (ætla, reyna), þurfa/eiga/verða að, bare-infinitive modals
(hyggjast, vilja, munu) and the perfect ("hefur ákveðið að"). It gets
a +10 score so that an nf/þf-ambiguous noun phrase is read as the
subject rather than a fronted object with a gapped subject.
- "Þar sem kvartandi hefði ekki haft aðild var úrskurðarnefndinni
óheimilt að taka málið til efnismeðferðar": a dative subject with an
adjective (óheimilt, ljóst, frjálst, ...) after the verb when
something else is fronted. New SögnMeðF_0 alternative, the inverted
counterpart of BeygingarliðurLoÞgf.
- Agent nouns in -andi ('kvartandi', 'kærandi', 'nemandi', ...) lost to
the present participle reading as subjects, since the reducer gives
LHNT terminals +12. A sweep of the 422 BÍN forms that are both a kk
-andi noun and a participle found 303 such losses; Prefs.conf now
demotes the participle (<<<) for 46 clear agent/role nouns, and the
existing eigandi/notandi/frambjóðandi entries are raised from << to
<<<. Words with a real predicative adjective use (lesandi, mælandi,
...) demote only the participle; 'gerandi' and 'þolandi' prefer the
noun also as a predicate. Participle-dominant words (lifandi,
komandi, ráðandi, ...) are deliberately left alone, as is 'svarandi'
("svarandi til").
- 'þolandi' is masculine, not the rare feminine noun (noun preference),
and 'hafði' is the verb, not the weak form of the adjective 'hafður'.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- "bókin sem hann skrifaði": a subject and a transitive verb whose
object is the gap. These were parsed with the subject as a fronted
object ("sem [hann] skrifaði" = OVS) or with the verb read
intransitively, losing its object frame. New SagnRunaStýfðAndlag
(+10) covers finite and perfect verbs with an oblique object.
- "málið sem nefndin fjallaði um": the gap is the object of a
preposition, which is left stranded. New SagnRunaStýfðFs (+14) covers
finite, perfect, infinitive (ætla/þurfa að, modals, progressive 'vera
að') and verb + object ("staðurinn sem ég sagði þér frá"). The
stranded preposition is shown as ADVP ao, as already done for
impersonal passives ("kallað var eftir"). The object wrapper
NlAndlagStrönduðFs is tagged 'keep' so that the grammar compiler does
not shortcut it away and lose its NP-OBJ label.
- New TengisetningÞolStrönduðFs for the impersonal passive with a
stranded preposition in all word orders ("kallað var/verður eftir",
"var kallað eftir", "kallað hefur verið eftir", "hefur verið kallað
eftir"); without it the new rules read 'kallað' as a subject. The
expected tree in test_relative_clause changes accordingly: it used to
read 'kallað' as a predicative adjective.
- SagnRunaStýfðNh is raised from +10 to +14 so that an infinitive stays
inside the relative clause ("(ég gleymdi bókinni) sem ég ætlaði að
lesa"), and gets the progressive "sem ég var að lesa".
Known gaps: 'vera' + stranded preposition ("húsið sem hann hefur verið
í") and multi-word stranded prepositions ("sem hún tók á móti").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits of grammar and disambiguation work (plus a merge of master for the dependabot bumps). All 177 tests pass locally; ruff and mypy are clean.
5db0724: gapped infinitive relatives, inverted dative subjects, -andi nouns
SetningAukafallÁnF).SagnRunaStýfðNhcovers ætla/reyna að, þurfa/eiga/verða að, hyggjast/vilja/munu, perfect ("hefur ákveðið að") and progressive ("var að"). The score is +14, so nf/þf-ambiguous NPs are read as the subject and the infinitive stays inside the relative clause.LoÞgfNh) after a fronted element. NewSögnMeðF_0alternative, the counterpart ofBeygingarliðurLoÞgf.Prefs.confnow demotes the participle (<<<) for 46 clear agent/role nouns. eigandi, notandi and frambjóðandi go from<<to<<<. Words with a real adjective use (lesandi, mælandi, …) demote onlyso. Participle-dominant words (lifandi, komandi, ráðandi, …) are left alone, and so is svarandi ("svarandi til").d7534b5: object-gapped and stranded-preposition relatives
SagnRunaStýfðAndlag(subject + transitive verb, object gapped). This replaces OVS misreadings ("sem [hann] skrifaði") and intransitive readings that lost the object frame.SagnRunaStýfðFs. The stranded preposition is shown asADVP ao, as already done for impersonal passives. NewTengisetningÞolStrönduðFshandles impersonal passives with a stranded preposition in all word orders.simpletree.py:StrönduðFs→ ADVP,NlAndlagStrönduðFs→ NP-OBJ (taggedkeepso the grammar compiler does not shortcut it),TengisetningÞolStrönduðFs→ IP.Worth a look when reviewing
test_relative_clausenow expects a different tree for "Þetta eru lausnirnar sem kallað hefur verið eftir". The old expectations read kallað as a predicate adjective.<<<, "Ástandið er ekki þolandi" reads þolandi as a noun. This is accepted because the noun is far more frequent.🤖 Generated with Claude Code