Conversation
@standard-server/aws-lambda
@standard-server/core
@standard-server/fastify
@standard-server/fetch
@standard-server/node
@standard-server/peer
@standard-server/shared
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Pin pnpm to exact
12.4.2—devEngines.packageManager.versionchanges from the^12.4.1range to the exact12.4.2, making pnpm upgrades explicit and stopping Corepack from resolving the newest 12.x release out from under a frozen lockfile. - Lockfile re-provisioned —
pnpm-lock.yamlupdates thepackageManagerDependencies.pnpmspecifier/version and thepnpmplus 14@pnpm/exe.*package and snapshot entries to12.4.2; the diff is confined to those blocks as the body describes.
The lockfile specifier matches package.json exactly and the regenerated sections are internally consistent. The repo has no other pnpm version reference: every workflow uses pnpm/action-setup@v6 without a version input, and there is no .npmrc, .node-version, .tool-versions, mise.toml, Dockerfile, or doc mentioning a pnpm version. No actionable findings.
ℹ️ Node 26 matrix leg is red on an unrelated step
test_node_matrix (26) failed at pnpm runtime set deno 2, before pnpm i ran. The other three legs (20/22/24) executed the same pnpm 12.4.2 and the same step successfully, so this is not attributable to the version pin.
Technical details
# Node 26 leg fails during runtime provisioning
## Affected sites
- `.github/workflows/ci.yaml:41` — `pnpm runtime set deno 2` fails only on the Node 26 leg (job 105063143439); the subsequent `pnpm i` and `pnpm run test:coverage` steps are skipped.
## Required outcome
- None for this PR — re-running the leg should confirm the known deno-provisioning flake.
## Open questions for the human (optional)
- Is deno provisioning flaky enough to warrant a retry around `pnpm runtime set deno 2`?DeepSeek Flash (default — pick a model for stronger reviews) | 𝕏

Pins pnpm to exactly 12.4.2 in
devEngines.packageManagerinstead of the^12.4.1range, and records 12.4.2 inpnpm-lock.yaml, the same change as middleapi/orpc#2036. With a range, Corepack 0.36.0+ resolves the newest pnpm on npm, and pnpm does not switch to the lockfile's version when Corepack starts it, so every new 12.x release madepnpm install --frozen-lockfilefail withERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILEuntil the lockfile was refreshed.Behavior
devEngines.packageManager.version, then runpnpm install --lockfile-only.packageManagerDependenciesblock and thepnpm/@pnpm/exe.*entries.Testing
CI=trueand cold caches,pnpm install --frozen-lockfilefails onmainwithERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILEand passes on this branch with pnpm 12.4.2.eslintandsherifpass.