[Trivikram Kamat (trivikr)]

If one report in the final workspace/diagnostic response failed to convert, the whole pull was rejected, and after 6 such failures workspace pulls stopped for the session. This logs and skips the failing report instead, the same way the partial-result handler already does.

• DiagnosticRequestor: the final-result loop in provideWorkspaceDiagnostics now catches a failed convertReport call, logs Converting workspace diagnostics failed., and keeps the other reports. Before, a single bad item (e.g. a diagnostic with an empty message, which VS Code rejects with message must be set) dropped every report and incremented workspaceErrorCounter.
• The progress-handler leak test from fd6d380 used this rejection to reach the finally path. It now expects the pull to resolve, and the unused expectRejection helper parameter is gone.

New test: a valid report next to one with an empty message delivers the valid report and logs the failure once.

[Copilot]

🟡 Changes recommended

The new error call enables repeated user notifications during background polling instead of only logging conversion failures.

1 open issue

• Suppress repeated error notifications for malformed workspace reports · New

What changed in this PR

This PR isolates conversion failures in final workspace diagnostic responses so one malformed report no longer rejects the entire pull or eventually stops workspace polling.

Changes:

• Catch and log conversion failures per report while preserving valid reports.
• Update progress-handler cleanup tests to expect successful pulls.
• Add regression coverage for mixed valid and malformed reports.

File	Description
client/​src/​common/​diagnostic.ts	Skip individual reports that fail conversion in final responses.
client-node-tests/​src/​integration.test.ts	Update cleanup expectations and test malformed-report isolation.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The focused change matches existing partial-result handling, preserves cleanup, and includes regression coverage with no unresolved findings.

No open issues 🎉

1 resolved since last review

• Suppress repeated error notifications for malformed workspace reports

_{Review effort: Balanced}