Skip to content

Land shared non-Functions changes from the Functions migration - #396

Merged
Brandon Waterloo (bwateratmsft) merged 3 commits into
mainfrom
bwateratmsft-shared-non-functions-changes
Oct 29, 2026
Merged

Brandon Waterloo (bwateratmsft) merged 3 commits into
mainfrom
bwateratmsft-shared-non-functions-changes

Conversation

@bwateratmsft

@bwateratmsft Brandon Waterloo (bwateratmsft) commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

🤖

Summary

Carves the changes in #367 that are not specific to Azure Functions into their own PR so they can land on main first. Every included hunk is taken verbatim from the Functions branch (fd28d293), so merging main back into it should be conflict-free (verified with a trial merge).

  • Pseudoterminal / Container Apps logs: BufferedPseudoterminal.endOnKeyPress(...lines) and handleInput; ContainerAppLogStream uses it when a stream breaks. Docs: docs/conventions.md.
  • Process execution: IProcessExecutor waits a 2 s grace period (WindowsLauncherExitGraceMs) after a Windows launcher exits before reporting that the process tree could not be terminated. Docs: docs/architecture.md.
  • Resource navigation: AzureNodeId.forRelatedResource canonicalizes subscriptions/resourceGroups/providers (App Service returns resourcegroups); GenericAzureViewProvider.getTreeItem returns an id-only item for an unloaded key, because TreeView.reveal asks for the target's item before loading its parent's children.
  • REST errors: assertRestSuccess appends identifier-shaped service error codes (never messages); tested through the existing LogsQueryClient.test.ts.

Untrusted-workspace support is intentionally not part of this PR: the extension does not declare untrustedWorkspaces, so VS Code disables it in Restricted Mode. Doing it properly (enforcing trust in code) is tracked in #397.

Testing

Run from the repo root on Node 24:

  • pnpm run lint - passed (exit 0)
  • pnpm run build - passed (exit 0)
  • pnpm run test - passed (exit 0; extension suite: 1257 passing, 4 pending)

New/changed tests: BufferedPseudoterminal, ContainerAppLogStream, IProcessExecutor (grace period, fake timers), AzureNodeId, GenericAzureViewProvider, LogsQueryClient (error codes).

Checklist

  • I followed the repository conventions in docs/ and CONTRIBUTING.md
  • pnpm run lint, pnpm run build, and pnpm run test pass
  • New and changed behavior is covered by tests (fast and deterministic, or registered as long-running)
  • The change follows the VS Code UX guidelines and the repository's UX conventions
  • User-facing strings are localized
  • No activation-time regressions; expensive work is deferred or lazy-loaded
  • Bundle size is unchanged, or the increase is justified below
  • Docs (docs/, READMEs, CHANGELOG.md) are updated where relevant
  • No secrets, PII, or raw telemetry data are included

Bundle size / performance

No impact.

Major contribution (new service, resource type, or substantial feature)

  • This is a major contribution. I agree to own this code long-term, and I understand it may be removed if its issues go unaddressed.
  • I have added or updated a CODEOWNERS entry for the code I'm contributing.

UI changes

None.

Pseudoterminal key-press ending for Container Apps log streams, Windows launcher-exit grace period, ARM keyword canonicalization in forRelatedResource, provisional tree items for unloaded keys, service error codes in REST errors, and workspace trust handling for the workspace index.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 29, 2026 19:27

This comment was marked as resolved.

The extension does not declare untrustedWorkspaces, so VS Code disables it in Restricted Mode. Supporting it needs in-code trust enforcement, which is deferred to a follow-up issue.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@bwateratmsft
Brandon Waterloo (bwateratmsft) merged commit 064f66d into main Oct 29, 2026
2 checks passed
@bwateratmsft
Brandon Waterloo (bwateratmsft) deleted the bwateratmsft-shared-non-functions-changes branch October 29, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants