Repository navigation
Land shared non-Functions changes from the Functions migration - #396
Merged
Brandon Waterloo (bwateratmsft) merged 3 commits intoOct 29, 2026
Merged
Brandon Waterloo (bwateratmsft) merged 3 commits into
Brandon Waterloo (bwateratmsft) merged 3 commits into
Conversation
Pseudoterminal key-press ending for Container Apps log streams, Windows launcher-exit grace period, ARM keyword canonicalization in forRelatedResource, provisional tree items for unloaded keys, service error codes in REST errors, and workspace trust handling for the workspace index. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The extension does not declare untrustedWorkspaces, so VS Code disables it in Restricted Mode. Supporting it needs in-code trust enforcement, which is deferred to a follow-up issue. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Alex Weininger (alexweininger)
approved these changes
Oct 29, 2026
Brandon Waterloo (bwateratmsft)
deleted the
bwateratmsft-shared-non-functions-changes
branch
October 29, 2026 20:27
10 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Carves the changes in #367 that are not specific to Azure Functions into their own PR so they can land on
mainfirst. Every included hunk is taken verbatim from the Functions branch (fd28d293), so mergingmainback into it should be conflict-free (verified with a trial merge).BufferedPseudoterminal.endOnKeyPress(...lines)andhandleInput;ContainerAppLogStreamuses it when a stream breaks. Docs:docs/conventions.md.IProcessExecutorwaits a 2 s grace period (WindowsLauncherExitGraceMs) after a Windows launcher exits before reporting that the process tree could not be terminated. Docs:docs/architecture.md.AzureNodeId.forRelatedResourcecanonicalizessubscriptions/resourceGroups/providers(App Service returnsresourcegroups);GenericAzureViewProvider.getTreeItemreturns an id-only item for an unloaded key, becauseTreeView.revealasks for the target's item before loading its parent's children.assertRestSuccessappends identifier-shaped service error codes (never messages); tested through the existingLogsQueryClient.test.ts.Untrusted-workspace support is intentionally not part of this PR: the extension does not declare
untrustedWorkspaces, so VS Code disables it in Restricted Mode. Doing it properly (enforcing trust in code) is tracked in #397.Testing
Run from the repo root on Node 24:
pnpm run lint- passed (exit 0)pnpm run build- passed (exit 0)pnpm run test- passed (exit 0; extension suite: 1257 passing, 4 pending)New/changed tests:
BufferedPseudoterminal,ContainerAppLogStream,IProcessExecutor(grace period, fake timers),AzureNodeId,GenericAzureViewProvider,LogsQueryClient(error codes).Checklist
pnpm run lint,pnpm run build, andpnpm run testpassdocs/, READMEs,CHANGELOG.md) are updated where relevantBundle size / performance
No impact.
Major contribution (new service, resource type, or substantial feature)
CODEOWNERSentry for the code I'm contributing.UI changes
None.