Use native private members in core tooling - #5943
Open
Bharat Middha (bmiddha) wants to merge 3 commits into
Open
Use native private members in core tooling#5943Bharat Middha (bmiddha) wants to merge 3 commits into
Bharat Middha (bmiddha) wants to merge 3 commits into
Conversation
Convert TS private class property declarations to native #private fields across api-extractor, api-documenter, and core libraries, stripping the conventional leading underscore. Excludes node-core-library: its bundled rollup .d.ts is consumed by ES5-target build-test fixtures, and #private syntax anywhere in that file breaks their typecheck (TS18028). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14
Convert TypeScript private method and getter/setter declarations to native #private syntax across api-documenter, api-extractor, api-extractor-model, credential-cache, debug-certificate-manager, heft-config-file, lookup-by-path, npm-check-fork, operation-graph, package-extractor, stream-collator, terminal, ts-command-line, typings-generator, worker-pool, and doc-plugin-rush-stack, stripping the conventional leading underscore. Extends the prior #private field conversion to methods and accessors using the same symbol-aware tool. Adds an eslint-disable-next-line @rushstack/no-new-null suppression to SourceMapper#getSourceMap, matching the existing suppression on its sibling private field, since converting the method to native #private syntax exposed it to the same decoupled-lint-rule gap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14
Bharat Middha (bmiddha)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#privatemembersnode-core-libraryTypeScript-private members whose rolled-up declarations are consumed by ES5-target fixtures, where native private declarations fail with TS18028Validation