fix(fetch): match Content-Type header case-insensitively - #3210
Open
Alexandre Kohler (kwy404) wants to merge 1 commit into
Open
Alexandre Kohler (kwy404) wants to merge 1 commit into
Alexandre Kohler (kwy404) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_json_content_typeonly matched the exact header nameContent-Type, so a request sent withcontent-type: application/jsonhad its stringdatapassed through unchanged instead of being treated as JSON. Header names are case-insensitive and Playwright for JS already compares them that way, so the check now lowercases the name.The lowercase header case is covered by the new
test_should_json_stringify_string_body_when_content_type_is_application_jsonintests/async/test_fetch_global.py.