Skip to content

fix(fetch): accept float values for data #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexandre Kohler (kwy404) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(fetch): accept float values for data #3209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright/_impl/_fetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ async def _inner_fetch(
post_data_buffer = data.encode()
elif isinstance(data, bytes):
post_data_buffer = data
elif isinstance(data, (dict, list, int, bool)):
elif isinstance(data, (dict, list, int, float, bool)):
json_data = json.dumps(data)
else:
raise Error(f"Unsupported 'data' type: {type(data)}")
Expand Down
1 change: 1 addition & 0 deletions tests/async/test_fetch_global.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,7 @@ async def test_should_serialize_request_data(
([], "[]"),
({}, "{}"),
("", ""),
(1.5, "1.5"),
]:
response = await request.post(server.PREFIX + "/echo", data=data)
assert response.status == 200
Expand Down