Fix percent-encoded Windows drive paths in file URIs - #2315
Draft
zhewen tan (tandede) wants to merge 1 commit into
Draft
Fix percent-encoded Windows drive paths in file URIs#2315zhewen tan (tandede) wants to merge 1 commit into
zhewen tan (tandede) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
zhewen tan (tandede)
force-pushed
the
agent/decode-windows-file-uri-drive
branch
from
August 19, 2026 01:17
5d9ad89 to
0cc54c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix percent-encoded Windows drive separators in
file:URIs so paths such asfile:///C%3A/Temp/example.mdresolve toC:\Temp\example.mdinstead of retaining a leading separator that causes the current drive to be prepended again.url2pathname()checks for a DOS drive before percent-decoding the path. When the colon is encoded, that check misses the drive and leaves a leading separator in the decoded Windows path. The conversion now removes that separator only when the decoded path has Windows drive syntax; POSIX and UNC paths are unchanged.A platform-independent regression test emulates Windows path handling and verifies the encoded URI result.
Fixes #2208
Test plan
hatch test— 337 passed, 4 skippedhatch run types:check src/markitdown/_uri_utils.py tests/test_module_misc.pypre-commit run --all-files