feat: add legacy .doc conversion support - #2307
Open
mikemikimike wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #23
Summary
Adds optional conversion support for legacy binary
.docfiles using theunwordparser.Implementation
DocConverter, which recognizes.docfiles and returns the parser's body text as Markdown.docoptional dependency and included it in theallfeature..docxconverter.Compatibility
Existing
.docxand other converters are unchanged..docsupport is opt-in throughmarkitdown[doc]or included inmarkitdown[all]. Rich layout extraction is limited to the text exposed byunword.Validation
python -m pytest tests/test_doc_converter.py -q— 3 passed.python -m mypy --ignore-missing-imports src/markitdown/converters/_doc_converter.py tests/test_doc_converter.py— passed.python -m black --check src/markitdown/converters/_doc_converter.py tests/test_doc_converter.py— passed.python -m pre_commit run --all-files— passed.python -m pytest -q --basetemp=.pytest-tmp— not fully green in this Windows environment: existing CLI vector tests encounter GBK decoding errors, andtest_file_urisexpects Unix-style paths. The focused and unaffected tests passed before those environment-specific failures.Limitations
No binary
.docfixture is included; extensionless MIME sniffing and rich layout reconstruction are out of scope.