Fix default scalar values in command output - #305
Open
RKS (rksharma-owg) wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default integer and string command arguments currently become
{"isDefault": true}in output.todictreads the marker classes'__dict__, losing the value the command returned.Convert
DefaultIntandDefaultStrto their built-in scalar types before object conversion. Regression coverage checks direct and nested results, built-in output types, and retention of the original default marker.Fixes #215.
Validation on macOS, Python 3.12.13:
pytest: 246 passed, 2 subtests passed.knack/_win_vt.py:40; it also reproduces when linting that unchanged module alone.AI assistance: Codex assisted with investigation, implementation, and local verification.