Repository navigation
serializer: support checked SNP ID block replacement - #137
Merged
Chris Oo (chris-oo) merged 1 commit intoOct 29, 2026
Merged
Conversation
Ming-Wei Shih (mingweishih)
force-pushed
the
legacy-hcl-endorsements
branch
from
October 3, 2026 00:13
2262709 to
49caa4b
Compare
Chris Oo (chris-oo)
left a comment
Chris Oo (chris-oo)
left a comment
Member
There was a problem hiding this comment.
looks fine other than the cargo.toml change i don't think is needed anymore
Preserve image identity and directive order when applying externally signed ID-block authentication. Validate policy, launch digest, and unambiguous SNP context, and recheck appended directives at serialization. Signed-off-by: Ming-Wei Shih <mishih@microsoft.com>
Ming-Wei Shih (mingweishih)
force-pushed
the
legacy-hcl-endorsements
branch
from
October 28, 2026 22:52
49caa4b to
9441a0a
Compare
Chris Oo (chris-oo)
approved these changes
Oct 29, 2026
Ming-Wei Shih (mingweishih)
added a commit
to mingweishih/openvmm
that referenced
this pull request
Nov 3, 2026
Support external signing workflows for existing IGVM images without rebuilding them or substituting image identity defaults. Keep CoRIM endorsement preparation separate from SNP ID-block signing. - Add prepare-endorsement and verify-endorsement for SNP, TDX, and VBS, with signing artifacts, hash provenance, and verification of the selected endorsement without permitting unrelated image changes. - Add prepare-snp-id-block with an optional decoded JSON dump and add-snp-id-block --replace-existing for identity-preserving external signatures. Validate existing signatures or unsigned placeholders. - Derive SNP endorsement SVN from an existing ID block, or require an explicit SVN when absent, as for TDX/VBS. Reject mismatches in both CoRIM preparation and ID-block addition or replacement. - Allow explicit firmware DLL resource and language selection for inspection and finalized endorsement verification. - Pin igvm and igvm_defs to upstream revision 568e2719972e, including checked SNP ID-block replacement from microsoft/igvm#137. - Document the independent signing workflows and trust boundaries in the igvmfilegen tool guide. Signature verification does not establish signer authorization or certificate trust. Validation: igvmfilegen Clippy (all targets), rustdoc, all 96 unit tests, cargo xtask fmt --fix, and git diff --check passed. Hardware acceptance was not tested. Signed-off-by: Ming-Wei Shih <mishih@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve image identity and directive order when applying externally signed ID-block authentication. Validate policy, launch digest, and unambiguous SNP context, and recheck appended directives at serialization.