Skip to content

fix(examples): separate Minikube host and agent gateway URLs - #633

Open
Bluu (Bluuok) wants to merge 1 commit into
microsoft:mainfrom
Bluuok:fix/calc-minikube-addresses
Open

Bluu (Bluuok) wants to merge 1 commit into
microsoft:mainfrom
Bluuok:fix/calc-minikube-addresses

Conversation

@Bluuok

@Bluuok Bluu (Bluuok) commented Oct 3, 2026 •

Copy link
Copy Markdown

The Calc-X Minikube launcher starts its controller on the host, but passes host.minikube.internal as the controller's gateway URL and leaves the pod-specific agent_url unset. This conflates the two network locations.

Use localhost for the host controller and set agl_server.agent_url to host.minikube.internal for agent pods, matching the documented controller configuration. Add an isolated test that executes the actual launcher, captures its overrides, composes the real configuration and builds a real Job manifest to verify both pod URLs.

Validation in the frozen Linux CPU environment:

python -m pytest tests/examples/test_calc_x_minikube.py -q -p no:cacheprovider
python -m ruff check tests/examples/test_calc_x_minikube.py
python -m ruff format --check tests/examples/test_calc_x_minikube.py
python -m pre_commit run --files examples/calc_x/run_minikube.sh tests/examples/test_calc_x_minikube.py
git diff --check

The regression failed on unchanged main and passed with the fix. Scoped Pyright passed with 0 errors; launcher content normalized to repository LF line endings passed bash -n. The test also verifies the key, runner type, TTL and arguments containing spaces, with synchronization for the background controller stub.

All Minikube, Ray, HTTP, service, cleanup and training commands are isolated mocks. No real cluster, network or GPU training was exercised. Ready for review based on the author-reported validation above; this maintenance pass did not rerun tests. The CLA check passed. Fork CI is awaiting maintainer approval (action_required, 0 jobs); no CI jobs have run. AI assistance was used; the two-file diff and generated manifest were reviewed.

@Bluuok
Bluu (Bluuok) marked this pull request as ready for review October 3, 2026 15:58
Copilot AI balanced review requested due to automatic review settings October 3, 2026 15:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused fix has regression coverage, and the targeted Python 3.12 compatibility check found no blocking issue.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes Calc-X Minikube networking by separating the host controller’s gateway URL from the URL used by agent pods.

Changes:

  • Uses localhost for the controller and host.minikube.internal for agents.
  • Adds an isolated launcher regression test covering configuration overrides and generated pod URLs.
File Description
tests/​examples/​test_calc_x_minikube.py Tests launcher arguments, configuration, and Job manifest URLs.
examples/​calc_x/​run_minikube.sh Sets separate host and agent gateway URLs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants