Repository navigation
Python: validate conversation metadata at the DevUI routes - #9861
Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
The create and update routes stored any JSON value as metadata, and one non-map entry made the conversation list copy raise for every caller until restart. Metadata is now validated at the boundary as a map of string keys to string values, with null treated as an empty map. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Manohar Paturi (ManoharPaturi)
temporarily deployed
to
github-app-auth
October 30, 2026 03:32 — with
GitHub Actions
Inactive
Manohar Paturi (ManoharPaturi)
requested review from
Darren Cohen (dargilco),
Jose Alvarez (jpalvarezl),
sophia-ramsey and
westey (westey-m)
as code owners
October 30, 2026 03:32
Manohar Paturi (ManoharPaturi)
temporarily deployed
to
github-app-auth
October 30, 2026 03:33 — with
GitHub Actions
Inactive
Contributor
Author
|
Understood, and sorry for jumping ahead. The issue now uses the Python bug report template with the verified reproduction, and I will leave this PR closed until the team agrees with the direction on #9860. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The DevUI conversation create and update routes accepted any JSON value as metadata and stored it verbatim. A string or null value survived the write, and the first conversation list call after that crashed with an attribute error while copying stored metadata, taking the whole list endpoint down until restart while single conversation reads kept working, so the failure looked random. The Conversations API contract for metadata is a map of string keys to string values, and the boundary should enforce it.
Description & Review Guide
Related Issue
Fixes #9860
AI Assistance
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.