Repository navigation
Python: Correct multimodal sample setup variables - #9735
Open
BlueRaddish wants to merge 1 commit into
Open
BlueRaddish wants to merge 1 commit into
BlueRaddish wants to merge 1 commit into
Conversation
AI-assisted with OpenAI Codex.
BlueRaddish
marked this pull request as ready for review
October 26, 2026 21:26
BlueRaddish
requested a review
from Eduard van Valkenburg (eavanvalkenburg)
as a code owner
October 26, 2026 21:26
BlueRaddish
temporarily deployed
to
github-app-auth
October 26, 2026 21:26 — with
GitHub Actions
Inactive
BlueRaddish
temporarily deployed
to
github-app-auth
October 26, 2026 21:26 — with
GitHub Actions
Inactive
Member
|
/review |
Contributor
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 37971e90165c
Model: gpt-5.6-sol
Overview
This documentation-only change aligns the multimodal samples with the environment variables that FoundryChatClient actually resolves. The full project-scoped endpoint follows the repository's sample guidance, and constructor checks plus settings tests confirm that both documented variables are required. No publishable risk was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The multimodal guide currently tells readers to configure Azure OpenAI variables, but both Azure-named scripts construct
FoundryChatClientand require the Foundry project endpoint and model variables. Following the documented configuration raisesValueError: Model is requiredbefore either example can run.Description & Review Guide
FOUNDRY_PROJECT_ENDPOINTandFOUNDRY_MODEL, including a full project-scoped endpoint example.azure_chat_multimodal.pyandazure_responses_multimodal.py. Both unchanged completemain()paths were exercised with real Foundry client construction and an offline response boundary: the original instructions fail twice, two explicit-configuration controls pass, and all four cases pass with the guide corrected. Normal scoped and native hooks pass, including whole-samples checks; nine hooks are nonapplicable. No live Azure credentials, network/model responses, full workspace unit suite or distribution build are claimed.Related Issue
N/A - trivial change. This is an obvious documentation correction to the environment variable names already required by the two adjacent sample scripts; the intended configuration is not in dispute.
AI Assistance
AI assistance details: OpenAI Codex assisted with identifying the documentation mismatch, the focused documentation change, offline verification and this description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.