Repository navigation
Python: drop the memory placeholder only when it is the sole entry - #9726
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
from_markdown filtered every bullet equal to the empty-list placeholder, so a genuine memory whose text happened to equal it was silently dropped on every read. The placeholder is now filtered once after parsing, and only when it is the sole entry, which is the only shape the write side emits for an empty memory list. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Manohar Paturi (ManoharPaturi)
requested review from
SergeyMenshykh,
Tao Chen (TaoChenOSU),
Eduard van Valkenburg (eavanvalkenburg),
Giles Odigwe (giles17),
Jose Alvarez (jpalvarezl),
Evan Mattson (moonbox3),
Roger Barreto (rogerbarreto),
sophia-ramsey and
westey (westey-m)
as code owners
October 26, 2026 17:53
Manohar Paturi (ManoharPaturi)
temporarily deployed
to
github-app-auth
October 26, 2026 17:53 — with
GitHub Actions
Inactive
Manohar Paturi (ManoharPaturi)
temporarily deployed
to
github-app-auth
October 26, 2026 17:53 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
to_markdown()writes- none yetas the placeholder for an empty memory list, andfrom_markdown()filtered every bullet equal to that text so the placeholder would not become a memory. The filter could not tell the placeholder from a real memory whose text happened to be exactlynone yet, so that memory was silently dropped on every read. Reproduced on main: a topic written with["none yet", "real fact"]reads back as["real fact"], and the loss repeats on every reparsing pass.Description & Review Guide
Related Issue
Fixes #9725
AI Assistance