Repository navigation
Python: Consolidate tooling helper fixes - #9706
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The three fixes are narrowly scoped, preserve surrounding behavior, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR consolidates three small fixes to existing Python repository helpers, restoring compatibility and Markdown behavior without changing workflows or test infrastructure.
Changes:
- Allow the hidden
--projectalias to satisfy the required dependency package selector. - Treat Markdown paths literally in
--no-globmode. - Escape pipes in displayed test names while preserving report identifiers and history data.
| File | Description |
|---|---|
python/scripts/integration_test_report/aggregate.py |
Escape test-name pipes to preserve Markdown table columns. |
python/scripts/dependencies/add_dependency_to_project.py |
Validate the shared selector after parsing so the legacy alias works. |
python/scripts/check_md_code_blocks.py |
Escape glob metacharacters when selecting literal Markdown paths. |
Review effort: Balanced
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): c23e77ce90bd
Model: gpt-5.6-sol
Overview
The PR narrowly restores three helper contracts: literal Markdown paths no longer expand metacharacters, the hidden dependency selector alias reaches the shared destination, and displayed test names escape table delimiters without changing persisted result keys. Existing validation and resolution guards constrain the changes, and no Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
Three small repository helpers have compatibility or Markdown-rendering behavior that does not match their existing contracts: the dependency wrapper rejects its hidden legacy
--projectselector, Markdown--no-globmode still interprets metacharacters, and integration trend tables split parameterized test names containing pipes into extra columns.This consolidates the useful behavior from three now-closed PRs into one deliberately minimal replacement, without adding a test harness or expanding workflow collection.
Description & Review Guide
-P/--packageor the hidden--projectalias satisfies it; escape literal Markdown paths before passing them toglob.globin--no-globmode; escape pipes only in displayed short test names when building integration trend Markdown tables.ruff check --no-fix --select E4,E7,E9,F,I, range-format checks passed for each edited region, andgit diff --checkpassed. Validation is intentionally lightweight because these scripts are excluded from the workspace-wide Ruff surface and have no existing appropriate regression modules.Related Issue
N/A - trivial change. These are narrow corrections to existing helper contracts whose desired behavior is already explicit. This consolidated replacement supersedes #9674, #9691, and #9692 while intentionally keeping implementation and validation lightweight. No competing open PR was found.
AI Assistance
AI assistance details: Copilot assisted with implementation, focused validation, and this PR description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.